Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/improve deepstrict equal debug message #19629

Closed
wants to merge 4 commits into from
Closed

Test/improve deepstrict equal debug message #19629

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ed311e
Change the string to a template literal to request done/sent values
q3e Mar 27, 2018
70f8f73
test: improve assert.strictEqual() with response_done & response_sent
q3e Mar 27, 2018
1d5300e
Merge branch 'test/improve-deepstrict_equal-debug-message' of github.…
q3e Mar 27, 2018
b891f55
Make message to a comment and omit the message parameter entirely
q3e Mar 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-http-client-timeout-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,6 @@ server.listen(0, options.host, function() {

process.on('exit', function() {
console.error(`done=${requests_done} sent=${requests_sent}`);
assert.strictEqual(requests_done, requests_sent,
'timeout on http request called too much');
// check that timeout on http request was not called too much
assert.strictEqual(requests_done, requests_sent);
});