test: make test-http-expect-continue more strict #19669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test-http-expect-continue, verify that the request listener is not called.
lpinca
approved these changes
Mar 29, 2018
lpinca
added
the
author ready
jasnell
approved these changes
Mar 29, 2018
richardlau
approved these changes
Mar 29, 2018
Adsada2205
approved these changes
Mar 29, 2018
cjihrig
approved these changes
Mar 29, 2018
trivikr
approved these changes
Mar 29, 2018
|
All three CI failures are again the crash-with-no-stack track thing. @BridgeAR (Uh, let me know if I should stop pinging you on those.) Will re-run. In the meantime, for posterity: https://ci.nodejs.org/job/node-test-commit-linux/17450/nodes=debian8-64/console 00:39:13 not ok 1099 parallel/test-net-connect-buffer
00:39:13 ---
00:39:13 duration_ms: 0.328
00:39:13 severity: fail
00:39:13 stack: |-
00:39:13 ...https://ci.nodejs.org/job/node-test-commit-linux/17450/nodes=debian8-x86/console 00:38:58 not ok 1079 parallel/test-https-truncate
00:38:58 ---
00:38:58 duration_ms: 0.509
00:38:58 severity: fail
00:38:58 stack: |-
00:38:58 ...https://ci.nodejs.org/job/node-test-commit-linux/17450/nodes=alpine-latest-x64/console 00:40:57 not ok 2079 sequential/test-http2-session-timeout
00:40:57 ---
00:40:57 duration_ms: 1.917
00:40:57 severity: fail
00:40:57 stack: |-
00:40:57 (node:25435) ExperimentalWarning: The http2 module is an experimental API.
00:40:57 assert.js:80
00:40:57 throw new AssertionError(obj);
00:40:57 ^
00:40:57
00:40:57 AssertionError [ERR_ASSERTION]: function should not have been called at /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/test/sequential/test-http2-session-timeout.js:11
00:40:57 at Http2Server.mustNotCall (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-latest-x64/test/common/index.js:531:12)
00:40:57 at Http2Server.emit (events.js:182:13)
00:40:57 at ServerHttp2Session.sessionOnTimeout (internal/http2/core.js:2505:15)
00:40:57 at Object.onceWrapper (events.js:275:13)
00:40:57 at ServerHttp2Session.emit (events.js:182:13)
00:40:57 at ServerHttp2Session._onTimeout (internal/http2/core.js:1270:10)
00:40:57 at ontimeout (timers.js:426:11)
00:40:57 at tryOnTimeout (timers.js:289:5)
00:40:57 at listOnTimeout (timers.js:252:5)
00:40:57 at Timer.processTimers (timers.js:212:10)
00:40:57 ... |
|
node-test-commit-linux rerun: https://ci.nodejs.org/job/node-test-commit-linux/17468/ |
|
Not sure what caused the lone CI failure this time (console output at https://ci.nodejs.org/job/node-test-commit-linux/17468/nodes=debian8-64/console), but it is build-related and unrelated to this change. @nodejs/build Re-running: https://ci.nodejs.org/job/node-test-commit-linux/17496/ |
|
(Last CI was green, so this can land in another 12 hours or so.) |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 31, 2018
In test-http-expect-continue, verify that the request listener is not called. PR-URL: nodejs#19669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in 085ad54 |
targos
pushed a commit
that referenced
this pull request
Apr 2, 2018
In test-http-expect-continue, verify that the request listener is not called. PR-URL: #19669 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test-http-expect-continue, verify that the request listener is not
called.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes