Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: favor utf16le over ucs2 in buffer.md #19688

Closed
wants to merge 1 commit into from
Closed

doc: favor utf16le over ucs2 in buffer.md #19688

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 30, 2018

Favor 'utf16le' over its alias 'ucs2' in buffer.md.

Ref: #19648 (comment)

Checklist

@Trott
doc: favor utf16le over ucs2 in buffer.md
0cabe09 
Favor 'utf16le' over its alias 'ucs2' in `buffer.md`.

Ref: nodejs#19648 (comment)
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Mar 30, 2018
@Trott
Copy link
Member Author

Trott commented Mar 30, 2018

@TimothyGu

@Trott
Copy link
Member Author

Trott commented Mar 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/361/

TimothyGu
TimothyGu approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as linter is happy with it.

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 30, 2018
@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 30, 2018
@Trott
Copy link
Member Author

Trott commented Mar 30, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/367/

@Trott
Copy link
Member Author

Trott commented Apr 2, 2018

Landed in 52a9f42

@Trott Trott closed this Apr 2, 2018
Trott added a commit to Trott/io.js that referenced this pull request Apr 2, 2018
@Trott
doc: favor utf16le over ucs2 in buffer.md
52a9f42 
Favor 'utf16le' over its alias 'ucs2' in `buffer.md`.

Ref: nodejs#19648 (comment)

PR-URL: nodejs#19688
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 2, 2018
@Trott @targos
doc: favor utf16le over ucs2 in buffer.md
d111037 
Favor 'utf16le' over its alias 'ucs2' in `buffer.md`.

Ref: #19648 (comment)

PR-URL: #19688
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Apr 4, 2018
Merged
@Trott Trott deleted the ucs2 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @jasnell @lpinca @TimothyGu @cjihrig @vsemozhetbyt @trivikr @nodejs-github-bot