-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppresses the runtime/sizeof cpplint error using Ben's suggestion via t... #197
Suppresses the runtime/sizeof cpplint error using Ben's suggestion via t... #197
Conversation
…a the NOLINT directive.
LGTM but can you update the commit log to conform to the template from CONTRIBUTING.md? Cheers. |
This has moved to #202. @rudi-cilibrasi you're able to update an existing PR. No need to open a new PR for every change. |
Thanks Colin. I hope you don't mind a question related to this about git. On Tue, Dec 23, 2014 at 8:12 AM, Colin Ihrig notifications@github.com
Happy to Code with Integrity : Software Engineering Code of Ethics and |
Yes, |
@rudi-cilibrasi Also |
# Conflicts: # src/crypto/crypto_timing.cc # src/node_buffer.cc # src/node_external_reference.h
...he NOLINT directive.