Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error enumerablility #19719

Closed
wants to merge 1 commit into from
Closed

Fix error enumerablility #19719

wants to merge 1 commit into from
+27 −19

Commits on Apr 4, 2018

  1. errors: make message non-enumerable 

    A error message should always be non-enumerable. This makes sure
that is true for dns errors as well. It also adds another check
in `common.expectsError` to make sure no other regressions are
introduced going forward.

Fixes nodejs#19716
    @BridgeAR
    BridgeAR committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    3f1ff96 View commit details
    Browse the repository at this point in the history