Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix links in vm.md #19721

Closed
wants to merge 1 commit into from
Closed

doc: fix links in vm.md #19721

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Replace absolute link with relative link.
  • Fix sorting in bottom references.

@vsemozhetbyt
doc: fix links in vm.md
5fa24db 
* Replace absolute link with relative link.
* Fix sorting in bottom references.
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 1, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels Apr 1, 2018
@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/375/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2018
@vsemozhetbyt
Copy link
Contributor Author

Landed in f89f798

@vsemozhetbyt vsemozhetbyt deleted the doc-rel-links branch April 1, 2018 13:29
vsemozhetbyt added a commit that referenced this pull request Apr 1, 2018
@vsemozhetbyt
doc: fix links in vm.md
f89f798 
* Replace absolute link with relative link.
* Fix sorting in bottom references.

PR-URL: #19721
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 1, 2018
Closed
targos pushed a commit that referenced this pull request Apr 2, 2018
@vsemozhetbyt @targos
doc: fix links in vm.md
bb32bc8 
* Replace absolute link with relative link.
* Fix sorting in bottom references.

PR-URL: #19721
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
@targos targos mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @lpinca @cjihrig @hiroppy @nodejs-github-bot