Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net,http2: merge write error handling & property names #19734

Closed
wants to merge 1 commit into from
Closed

net,http2: merge write error handling & property names #19734

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Apr 1, 2018

Merge error handling for net.Sockets and Http2Streams,
and align the callback property names as callback.

Refs: #19060

(This has become possible after #19551)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc fyi @aks-

@addaleax
net,http2: merge write error handling & property names
5d2a005 
Merge error handling for `net.Socket`s and `Http2Stream`s,
and align the callback property names as `callback`.

Refs: nodejs#19060
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 1, 2018
@jasnell jasnell requested a review from mcollina April 1, 2018 22:54
mcollina
mcollina approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member Author

addaleax commented Apr 5, 2018

CI: https://ci.nodejs.org/job/node-test-commit/17470/

@lpinca
Copy link
Member

lpinca commented Apr 6, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/14098/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2018
@addaleax
Copy link
Member Author

CI re-run: https://ci.nodejs.org/job/node-test-commit/17597/

@addaleax
Copy link
Member Author

Landed in 93967d0

@addaleax addaleax closed this Apr 12, 2018
@addaleax addaleax deleted the mergemore-19060 branch April 12, 2018 14:02
@addaleax addaleax added net Issues and PRs related to the net subsystem. http2 Issues or PRs related to the http2 subsystem. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 12, 2018
addaleax added a commit that referenced this pull request Apr 12, 2018
@addaleax
net,http2: merge write error handling & property names
93967d0 
Merge error handling for `net.Socket`s and `Http2Stream`s,
and align the callback property names as `callback`.

Refs: #19060

PR-URL: #19734
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 16, 2018
@addaleax @jasnell
net,http2: merge write error handling & property names
e85c20b 
Merge error handling for `net.Socket`s and `Http2Stream`s,
and align the callback property names as `callback`.

Refs: #19060

PR-URL: #19734
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@addaleax @BridgeAR
net,http2: merge write error handling & property names
abd324a 
Merge error handling for `net.Socket`s and `Http2Stream`s,
and align the callback property names as `callback`.

Refs: nodejs#19060

PR-URL: nodejs#19734
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@kjin kjin mentioned this pull request Sep 19, 2018
Closed
4 tasks
@addaleax addaleax mentioned this pull request Oct 20, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@aks- aks- aks- approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @lpinca @mcollina @jasnell @tniessen @aks- @trivikr @BridgeAR @nodejs-github-bot