Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: fix typo in openssl upgrading doc #19789

Closed
wants to merge 1 commit into from
Closed

deps: fix typo in openssl upgrading doc #19789

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 4, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the openssl Issues and PRs related to the OpenSSL dependency. label Apr 4, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 4, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14034/

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 4, 2018
@trivikr
Copy link
Member

trivikr commented Apr 4, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/425/

@trivikr trivikr added the doc Issues and PRs related to the documentations. label Apr 4, 2018
@tniessen
Copy link
Member

tniessen commented Apr 4, 2018

Landed in b22a189.

@tniessen tniessen closed this Apr 4, 2018
tniessen pushed a commit that referenced this pull request Apr 4, 2018
@danbev @tniessen
deps: fix typo in openssl upgrading doc
b22a189 
PR-URL: #19789
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 6, 2018
@danbev @targos
deps: fix typo in openssl upgrading doc
8cc261f 
PR-URL: #19789
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danbev danbev deleted the fix-typo-deps-openssl-doc-upgrading branch May 31, 2018 05:41
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@danbev @MylesBorins
deps: fix typo in openssl upgrading doc
c4f39f6 
PR-URL: #19789
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@danbev @MylesBorins
deps: fix typo in openssl upgrading doc
0494552 
PR-URL: #19789
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@danbev @MylesBorins
deps: fix typo in openssl upgrading doc
812b97c 
PR-URL: #19789
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gibfahn gibfahn gibfahn approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @trivikr @tniessen @lpinca @cjihrig @gibfahn @MylesBorins @vsemozhetbyt @nodejs-github-bot