Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: change the info to the same as in gitconfig #2000

Merged
merged 1 commit into from
Jun 18, 2015

Conversation

tellnes
Copy link
Contributor

@tellnes tellnes commented Jun 17, 2015

It was mentioned in #1966 that my gitconfig differ from what's in README.md. Both is correct, but here is an update. The name I'm removing is my middle name which most website does not let me enter anyway (As you now, most of them only supports first and lastname).

@yosuke-furukawa
Copy link
Member

LGTM (You got #2000 ! )

@yosuke-furukawa yosuke-furukawa added the doc Issues and PRs related to the documentations. label Jun 17, 2015
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@jbergstroem
Copy link
Member

LGTM

PR-URL: nodejs#2000
Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@tellnes tellnes merged commit 1f93b63 into nodejs:master Jun 18, 2015
@rvagg rvagg mentioned this pull request Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants