Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make process.env.TZ setter clear tz cache #20026

Merged
merged 1 commit into from
May 23, 2019

Commits on May 23, 2019

  1. src: make process.env.TZ setter clear tz cache

    Since the presence of the libc and V8 timezone caches seem to be
    a perennial source of confusion to users ("why doesn't it work?!"),
    let's try to support that pattern by intercepting assignments to
    the TZ environment variable and reset the caches as a side effect.
    
    Fixes: nodejs#19974
    PR-URL: nodejs#20026
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    bnoordhuis committed May 23, 2019
    Configuration menu
    Copy the full SHA
    eba348b View commit details
    Browse the repository at this point in the history