Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check result as early as possible #2007

Closed
wants to merge 1 commit into from
Closed

test: check result as early as possible #2007

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 18, 2015

Remove nested event listeners. Listen to pipe's finish event as it seems to be the earliest event to fire once results can be checked. Minor positive-ish effects:

  • Code is slightly easier to understand. (It wasn't that hard in the first place, though.)
  • In my non-scientific highly-questionable benchmarking on my laptop, the test seems to run approximately 10ms faster.
  • Allows us to remove a TODO comment in the tests

@rvagg
Copy link
Member

rvagg commented Jun 18, 2015

lgtm, but CI run please

@Trott
Copy link
Member Author

Trott commented Jun 18, 2015

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/45/

@mscdex mscdex added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. labels Jun 18, 2015
Trott added a commit that referenced this pull request Jun 20, 2015
@Trott
test: check result as early as possible
3ba4f71 
PR-URL: #2007
Reviewed-By: Rod Vagg <rod@vagg.org>
@Trott
Copy link
Member Author

Trott commented Jun 20, 2015

Merged in 3ba4f71

@Trott Trott closed this Jun 20, 2015
@Trott Trott deleted the test-micro-opt branch January 9, 2022 22:02
This was referenced Jun 22, 2023
Open
Open
Open
Open
This was referenced Jul 7, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @rvagg @mscdex