Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump V8 embedder string #20105

Closed
wants to merge 1 commit into from
Closed

deps: bump V8 embedder string #20105

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

This was missed in a previous PR

Refs: #20016

would like this to fast track to not block other V8 prs

@MylesBorins
deps: bump V8 embedder string
87f83ef 
This was missed in a previous PR

Refs: nodejs#20016
@MylesBorins MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 17, 2018
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Apr 17, 2018
@MylesBorins MylesBorins mentioned this pull request Apr 17, 2018
Closed
3 tasks
@targos
Copy link
Member

targos commented Apr 17, 2018

+1 to fast track

@targos targos mentioned this pull request Apr 17, 2018
Closed
4 tasks
@jasnell jasnell added this to the 10.0.0 milestone Apr 17, 2018
richardlau
richardlau approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to fast track.

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Apr 17, 2018 via email

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 17, 2018
@MylesBorins
Copy link
Contributor Author

landed in e86b319

MylesBorins added a commit that referenced this pull request Apr 17, 2018
@MylesBorins
deps: bump V8 embedder string
e86b319 
This was missed in a previous PR

PR-URL: #20105
Refs: #20016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
jasnell pushed a commit that referenced this pull request Apr 17, 2018
@MylesBorins @jasnell
deps: bump V8 embedder string
60eb95a 
This was missed in a previous PR

PR-URL: #20105
Refs: #20016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@MylesBorins @targos @jasnell @richardlau @devsnek @BridgeAR @nodejs-github-bot