Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: make process.env.TZ setter clear tz cache" #20228

Closed
wants to merge 1 commit into from
Closed

Revert "src: make process.env.TZ setter clear tz cache" #20228

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This reverts commit 1d1ab76.

Fixes: #20227

When landing #20026 I missed failures on Alpine and I could not find a easy way to detect Alpine builds right now, so I decided to revert this until we find a proper fix.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 23, 2018
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 23, 2018
@BridgeAR BridgeAR requested a review from bnoordhuis April 23, 2018 15:35
@BridgeAR
Copy link
Member Author

CI https://ci.nodejs.org/job/node-test-pull-request/14443/

@BridgeAR BridgeAR mentioned this pull request Apr 23, 2018
Closed
4 tasks
@BridgeAR
Copy link
Member Author

Landed in e767aa1

@BridgeAR BridgeAR closed this Apr 23, 2018
BridgeAR added a commit to BridgeAR/node that referenced this pull request Apr 23, 2018
@BridgeAR
Revert "src: make process.env.TZ setter clear tz cache"
e767aa1 
This reverts commit 1d1ab76.

PR-URL: nodejs#20228
Fixes: nodejs#20227
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failures
6 participants
@BridgeAR @jasnell @addaleax @joyeecheung @MylesBorins @nodejs-github-bot