Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typos in doc/changelogs/CHANGELOG_V10.md #20265

Closed
wants to merge 1 commit into from
Closed

doc: fix typos in doc/changelogs/CHANGELOG_V10.md #20265

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@vsemozhetbyt vsemozhetbyt added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 24, 2018
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 24, 2018
@vsemozhetbyt
Copy link
Contributor Author

Please, add 👍 here to approve fast-tracking.

@vsemozhetbyt

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR reviewed Apr 24, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message has to be fixed 😆

@vsemozhetbyt vsemozhetbyt changed the title doc: fox typos in doc/changelogs/CHANGELOG_V10.md doc: fix typos in doc/changelogs/CHANGELOG_V10.md Apr 24, 2018
@vsemozhetbyt
Copy link
Contributor Author

Fixed 😆
CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/582/

@vsemozhetbyt

This comment has been minimized.

Sign in to view
BridgeAR
BridgeAR approved these changes Apr 24, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2018
vsemozhetbyt added a commit that referenced this pull request Apr 24, 2018
@vsemozhetbyt
doc: fix typos in doc/changelogs/CHANGELOG_V10.md
317c2e1 
PR-URL: #20265
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 317c2e1

@vsemozhetbyt vsemozhetbyt deleted the doc-v10-typos branch April 24, 2018 23:06
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@vsemozhetbyt @MylesBorins
doc: fix typos in doc/changelogs/CHANGELOG_V10.md
26525ef 
PR-URL: #20265
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @devsnek @BridgeAR @nodejs-github-bot