doc: add parameters for settings events #20371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment)
nodejs-github-bot
added
doc
This comment has been minimized.
This comment has been minimized.
doc/api/http2.md
Outdated
| @@ -195,9 +195,10 @@ event is emitted. | |||
| added: v8.4.0 | |||
| --> | |||
|
|
|||
| * `settings` {Object} A copy of the `SETTINGS` frame received. | |||
There was a problem hiding this comment.
I wonder if this should be the {HTTP/2 Settings Object} as in other sections of this doc.
There was a problem hiding this comment.
It should! Didn't know that type existed, now I need to write the whole js file. 😛
doc/api/http2.md
Outdated
| @@ -215,9 +216,10 @@ session.on('localSettings', (settings) => { | |||
| added: v8.4.0 | |||
| --> | |||
|
|
|||
| * `settings` {Object} A copy of the `SETTINGS` frame received. | |||
vsemozhetbyt
approved these changes
Apr 27, 2018
vsemozhetbyt
added
the
fast-track
|
Please, add 👍 here to approve fast-tracking. |
trivikr
approved these changes
Apr 27, 2018
BridgeAR
approved these changes
Apr 29, 2018
BridgeAR
added
the
author ready
|
Landing this. |
|
Landed in e954aa0 |
ryzokuken
added a commit
that referenced
this pull request
Apr 30, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: #20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Aug 23, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 11, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Sep 19, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kjin
pushed a commit
to kjin/node
that referenced
this pull request
Oct 16, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) PR-URL: nodejs#20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Oct 17, 2018
Add parameters for the callback for the Http2Session:localSettings event and Http2Session:remoteSettings event inline with the pattern in the rest of the documentation. Refs: nodejs/help#877 (comment) Backport-PR-URL: #22850 PR-URL: #20371 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parameters for the callback for the Http2Session:localSettings event
and Http2Session:remoteSettings event inline with the pattern in the rest
of the documentation.
Refs: nodejs/help#877 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes/cc @nodejs/http2 @mcollina @vsemozhetbyt