Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update and fixed doc/guides/writing-and-running-benchmarks.md #20379

Closed
wants to merge 2 commits into from
Closed

doc: update and fixed doc/guides/writing-and-running-benchmarks.md #20379

wants to merge 2 commits into from

Conversation

xsbchen
Copy link
Contributor

@xsbchen xsbchen commented Apr 28, 2018

Refs: 368517c

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 28, 2018
@vsemozhetbyt
Copy link
Contributor

cc @nodejs/benchmarking

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/612/

@vsemozhetbyt vsemozhetbyt added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 28, 2018
joyeecheung
joyeecheung approved these changes Apr 28, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the commit message headline shortened

trivikr
trivikr reviewed Apr 28, 2018
View reviewed changes
doc/guides/writing-and-running-benchmarks.md
string_decoder/string-decoder.js n=250000 chunk=1024 inlen=1024 encoding=base64-utf8 23.60 % *** 2.105625e-12
string_decoder/string-decoder.js n=250000 chunk=1024 inlen=1024 encoding=utf8 14.04 % *** 1.291105e-07
string_decoder/string-decoder.js n=250000 chunk=1024 inlen=128 encoding=ascii 6.70 % * 2.928003e-02
confidence improvement accuracy (*) (**) (***)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The last three columns are not aligned in private branch:
screen shot 2018-04-28 at 2 05 28 pm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy from console log，should I fixed it in doc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc might be using different whitespaces as compared to console.log
It's a nit, check if you can add some spaces to align the columns in the doc. When I ran benchmark script, the last three columns were aligned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😄

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2018
@trivikr
Copy link
Member

trivikr commented May 3, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/652/

trivikr pushed a commit that referenced this pull request May 3, 2018
@xsbchen @trivikr
doc: update writing-and-running-benchmarks.md
751c2d6 
Refs: 368517c

PR-URL: #20379
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@trivikr
Copy link
Member

trivikr commented May 3, 2018

Landed in 751c2d6

Congratulations @xsbchen on your first commit in Node.js core! 🎉 🎉 🎉

@trivikr trivikr closed this May 3, 2018
@xsbchen
Copy link
Contributor Author

xsbchen commented May 3, 2018

Thanks for your help @trivikr

MylesBorins pushed a commit that referenced this pull request May 4, 2018
@xsbchen @MylesBorins
doc: update writing-and-running-benchmarks.md
bd8e626 
Refs: 368517c

PR-URL: #20379
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@xsbchen @MylesBorins
doc: update writing-and-running-benchmarks.md
b0ed31c 
Refs: 368517c

PR-URL: #20379
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xsbchen @vsemozhetbyt @trivikr @joyeecheung @BridgeAR @nodejs-github-bot