doc: document that repl uses domain module for error handling
#20382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
doc/api/repl.md
Outdated
| @@ -617,4 +628,9 @@ see: https://gist.github.com/2053342 | |||
| [`readline.Interface`]: readline.html#readline_class_interface | |||
| [`util.inspect()`]: util.html#util_util_inspect_object_options | |||
| [curl(1)]: https://curl.haxx.se/docs/manpage.html | |||
| [`domain`]: domain.html | |||
There was a problem hiding this comment.
Nit: these references are out of the ASCII sorting order that seems to be kept here.
There was a problem hiding this comment.
@vsemozhetbyt fixed. PTAL
vsemozhetbyt
approved these changes
Apr 28, 2018
|
Please, add 👍 here to approve fast-tracking. |
vsemozhetbyt
added
fast-track
|
cc @nodejs/repl |
addaleax
approved these changes
Apr 28, 2018
trivikr
approved these changes
Apr 28, 2018
BridgeAR
approved these changes
Apr 29, 2018
cjihrig
approved these changes
May 1, 2018
|
I cannot apply the patch before landing: $ curl -L https://github.com/nodejs/node/pull/$PR_ID.patch | git am -3 --whitespace=fix
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 139 0 139 0 0 139 0 --:--:-- --:--:-- --:--:-- 165
100 3557 0 3557 0 0 3557 0 --:--:-- 0:00:01 --:--:-- 16316
Applying: doc: document that repl uses `domain` module for error handling
Applying: fixup: sorting in linkify references
error: sha1 information is lacking or useless (doc/api/repl.md).
error: could not build fake ancestor
Patch failed at 0002 fixup: sorting in linkify references
The copy of the patch that failed is found in: .git/rebase-apply/patchMaybe this need rebasing? |
jasnell
approved these changes
May 3, 2018
Document that REPL uses the `domain` module to handle uncaught exceptions, and the side effects caused by it. Fixes: nodejs#19998
AyushG3112
force-pushed
the
doc-repl-domain
branch
from
7b8e820 to
771edf7
Compare
|
@vsemozhetbyt Rebased. |
|
Landed in 1cf7ef6 |
vsemozhetbyt
pushed a commit
that referenced
this pull request
May 4, 2018
Document that REPL uses the `domain` module to handle uncaught exceptions, and the side effects caused by it. PR-URL: #20382 Fixes: #19998 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Document that REPL uses the `domain` module to handle uncaught exceptions, and the side effects caused by it. PR-URL: #20382 Fixes: #19998 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Document that REPL uses the `domain` module to handle uncaught exceptions, and the side effects caused by it. PR-URL: #20382 Fixes: #19998 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Document that REPL uses the `domain` module to handle uncaught exceptions, and the side effects caused by it. PR-URL: #20382 Fixes: #19998 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document that REPL uses the
domainmodule to handle uncaught exceptions, and the side effects caused by it.Fixes: #19998
Checklist
make -j4 lint-md(UNIX) passes