tools: dedupe property access in doc/type-parser #20387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
the
fast-track
nodejs-github-bot
added
doc
|
Please, add 👍 here to approve fast-tracking. |
tniessen
approved these changes
Apr 29, 2018
vsemozhetbyt
added
the
author ready
trivikr
approved these changes
Apr 29, 2018
BridgeAR
approved these changes
Apr 29, 2018
|
@vsemozhetbyt sorry for not being clear with my comment: if you just do: |
There is no need to get this property twice in this rather hot spot: if there is no such key, the `typeUrl` will be `undefined`, which suffices for the boolean check in the next line. For consistency, `undefined` can also be made the default value.
|
@BridgeAR I've updated the code and commit message. @BridgeAR, @tniessen, @trivikr Is this still OK for you? CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/622/ |
|
Yep. |
|
Landed in 1c530e8 |
vsemozhetbyt
added a commit
that referenced
this pull request
May 2, 2018
There is no need to get this property twice in this rather hot spot: if there is no such key, the `typeUrl` will be `undefined`, which suffices for the boolean check in the next line. For consistency, `undefined` can also be made the default value. PR-URL: #20387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
There is no need to get this property twice in this rather hot spot: if there is no such key, the `typeUrl` will be `undefined`, which suffices for the boolean check in the next line. For consistency, `undefined` can also be made the default value. PR-URL: #20387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesThere is no need to get this property twice in this rather hot spot: if there is no such key, the
typeUrlwill beundefined, which suffices for the boolean check in the next line.For consistency,
undefinedcan also be made the default value.