test: add fs/promises filehandle stat test #20492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test for fs/promises filehandle stat.
cjihrig
approved these changes
May 3, 2018
lpinca
approved these changes
May 3, 2018
trivikr
reviewed
May 3, 2018
| common.crashOnUnhandledRejection(); | ||
|
|
||
| async function validateStat() { | ||
| const filePath = path.resolve(tmpDir, 'tmp-read-file.txt'); |
There was a problem hiding this comment.
tmpDir is used used only once here.
Can we remove variable tmpDir and pass tmpdir.path here, so that there's no confusion between similar looking variables tmpdir and tmpDir
There was a problem hiding this comment.
@trivikr
Thank you. I fixed it.
trivikr
approved these changes
May 4, 2018
jasnell
approved these changes
May 4, 2018
|
CI rerun for node-test-commit-aix https://ci.nodejs.org/job/node-test-commit-aix/14731/ |
trivikr
added
the
author ready
trivikr
pushed a commit
that referenced
this pull request
May 5, 2018
Added test for fs/promises filehandle stat. PR-URL: #20492 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Added test for fs/promises filehandle stat. PR-URL: #20492 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Added test for fs/promises filehandle stat. PR-URL: #20492 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Added test for fs/promises filehandle stat. PR-URL: #20492 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test for fs/promises filehandle stat.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes