-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: remove unused freelist.h header #20544
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always easy enough to re-introduce if we do need it.
nodejs-github-bot
added
the
c++
Issues and PRs that require attention from people who are familiar with C++.
label
May 5, 2018
addaleax
added
the
lib / src
Issues and PRs related to general changes in the lib or src directory.
label
May 5, 2018
cjihrig
approved these changes
May 5, 2018
addaleax
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 5, 2018
bnoordhuis
approved these changes
May 6, 2018
jasnell
approved these changes
May 6, 2018
danbev
approved these changes
May 7, 2018
mmarchini
approved these changes
May 7, 2018
TimothyGu
approved these changes
May 7, 2018
Landed in 5bb5d61 |
addaleax
added a commit
that referenced
this pull request
May 9, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 12, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
addaleax
added a commit
that referenced
this pull request
Jun 29, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Always easy enough to re-introduce if we do need it. PR-URL: #20544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always easy enough to re-introduce if we do need it.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes