doc: update "Who to cc..." in COLLABORATOR_GUIDE #20564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
added
meta
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
This comment has been minimized.
This comment has been minimized.
BridgeAR
approved these changes
May 6, 2018
COLLABORATOR_GUIDE.md
Outdated
| @@ -831,7 +831,7 @@ LTS working group and the Release team. | |||
| | Subsystem | Maintainers | | |||
| | --- | --- | | |||
| | `benchmark/*` | @nodejs/benchmarking, @mscdex | | |||
| | `bootstrap_node.js` | @nodejs/process | | |||
| | `bootstrap/node.js` | @nodejs/process | | |||
There was a problem hiding this comment.
I am not sure: previous bootstrap_loaders.js was not mentioned here. Is it @nodejs/modules domain, not @nodejs/process?
Refs: 8484b40
There was a problem hiding this comment.
The loaders were originally part of bootstra_node.js. But I see your point about it being a loader. I personally think this is somewhat related.
There was a problem hiding this comment.
However, it seems your suggestion is valid as per #20554
So I will replace with bootstrap/*.
Some of the mentioned files seem to be moved or renamed.
lpinca
approved these changes
May 7, 2018
trivikr
approved these changes
May 7, 2018
tniessen
approved these changes
May 7, 2018
cjihrig
approved these changes
May 7, 2018
ryzokuken
approved these changes
May 7, 2018
vsemozhetbyt
added
the
author ready
|
Landed in 0452f11 |
vsemozhetbyt
added a commit
that referenced
this pull request
May 7, 2018
Some of the mentioned files seem to be moved or renamed. PR-URL: #20564 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Some of the mentioned files seem to be moved or renamed. PR-URL: #20564 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
Some of the mentioned files seem to be moved or renamed. PR-URL: #20564 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
Some of the mentioned files seem to be moved or renamed. PR-URL: #20564 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesSome of the mentioned files seem to be moved or renamed.