Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to libuv 1.20.3 #20585

Merged
merged 1 commit into from
May 9, 2018
Merged

deps: upgrade to libuv 1.20.3 #20585

merged 1 commit into from
May 9, 2018

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 7, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label May 7, 2018
@cjihrig
Copy link
Contributor Author

cjihrig commented May 8, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14710/

Only failure was on macOS:

not ok 2176 sequential/test-fs-readfile-tostring-fail
  ---
  duration_ms: 120.388
  severity: fail
  exitcode: -15
  stack: |-
    timeout

jasnell
jasnell approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with investigation of the macos issue.

@cjihrig
Copy link
Contributor Author

cjihrig commented May 9, 2018

Green macOS run: https://ci.nodejs.org/job/node-test-commit-osx/18400/.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2018
@cjihrig
deps: upgrade to libuv 1.20.3
60349bb 
Refs: nodejs#19377
PR-URL: nodejs#20585
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 60349bb into nodejs:master May 9, 2018
@cjihrig cjihrig deleted the libuv branch May 9, 2018 18:06
targos pushed a commit that referenced this pull request May 12, 2018
@cjihrig @targos
deps: upgrade to libuv 1.20.3
f69a823 
Refs: #19377
PR-URL: #20585
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.20.3
e751460 
Refs: #19377
PR-URL: #20585
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 5, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.20.3
49910ce 
Refs: nodejs#19377
PR-URL: nodejs#20585
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2018
@cjihrig @MylesBorins
deps: upgrade to libuv 1.20.3
c54f4bc 
Backport-PR-URL: #24103
Refs: #19377
PR-URL: #20585
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 12, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. libuv Issues and PRs related to the libuv dependency or the uv binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @bnoordhuis @jasnell @addaleax @nodejs-github-bot