Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: patch V8 to 6.6.346.31 #20603

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 6.6.346.31 #20603

wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented May 8, 2018 •
edited
Loading

Refs: v8/v8@6.6.346.27...6.6.346.31

note: v8/v8@76cab5f has already landed on master

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels May 8, 2018
@MylesBorins
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/14717/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1361/

/cc @nodejs/v8-update

@MylesBorins MylesBorins requested a review from targos May 8, 2018 15:29
@MylesBorins
Copy link
Contributor Author

/cc @nodejs/platform-aix

not ok 2158 sequential/test-benchmark-http
  ---
  duration_ms: 120.94
  severity: fail
  exitcode: -15
  stack: |-
    timeout
    
    http/bench-parser.js
    http/bench-parser.js n=1 len=1: 6,624.13968985778
    
    http/check_invalid_header_char.js
    http/check_invalid_header_char.js n=1 input="keep-alive": 5,836.48503525237
    
    http/check_is_http_token.js
    http/check_is_http_token.js n=1 key="\"\"": 6,448.700586831754
    
    http/chunked.js
    http/chunked.js c=1 len=1 n=1 benchmarker="test-double": 1
    
    http/client-request-body.js
    http/client-request-body.js method="write" len=1 type="asc" dur=0.1: 1,861.2244437247934
    
    http/cluster.js
    http/cluster.js c=1 len=1 type="asc" benchmarker="test-double": 1

@richardlau
Copy link
Member

/cc @nodejs/platform-aix
not ok 2158 sequential/test-benchmark-http

@MylesBorins #20389

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 8, 2018
@addaleax
Copy link
Member

addaleax commented May 9, 2018

@MylesBorins needs a rebase :)

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2018
targos
targos approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can now be updated to 6.6.346.32 if you want

@MylesBorins
Copy link
Contributor Author

landed in 1e98787

MylesBorins added a commit that referenced this pull request May 15, 2018
@MylesBorins
deps: patch V8 to 6.6.346.31
1e98787 
PR-URL: #20603
Refs: v8/v8@6.6.346.27...6.6.346.31
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@bricss bricss mentioned this pull request May 17, 2018
Merged
MylesBorins added a commit that referenced this pull request May 22, 2018
@MylesBorins
deps: patch V8 to 6.6.346.31
6ce589f 
PR-URL: #20603
Refs: v8/v8@6.6.346.27...6.6.346.31
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MylesBorins @richardlau @addaleax @targos @BridgeAR @nodejs-github-bot