v10.1.0 proposal

.gitignore

@@ -127,3 +127,4 @@ deps/v8/src/Debug/
 deps/v8/src/Release/
 deps/v8/src/inspector/Debug/
 deps/v8/src/inspector/Release/
+deps/v8/third_party/eu-strip/

CHANGELOG.md

@@ -33,7 +33,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V10.md#10.0.0">10.0.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V10.md#10.1.0">10.1.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V10.md#10.0.0">10.0.0</a><br/>
     </td>
     <td valign="top">
 <b><a href="doc/changelogs/CHANGELOG_V9.md#9.11.1">9.11.1</a></b><br/>

COLLABORATOR_GUIDE.md

@@ -416,14 +416,15 @@ longer be used.
 
 Node.js uses three Deprecation levels:
 
-* *Documentation-Only Deprecation* refers to elements of the Public API that are
-  being staged for deprecation in a future Node.js major release. An explicit
-  notice indicating the deprecated status is added to the API documentation
-  but no functional changes are implemented in the code. There will be no
-  runtime deprecation warnings emitted for such deprecations by default.
-  Documentation-only deprecations may trigger a runtime warning when Node.js
-  is started with the [`--pending-deprecation`][] flag or the
-  `NODE_PENDING_DEPRECATION=1` environment variable is set.
+* *Documentation-Only Deprecation* refers to elements of the Public API that
+  should be avoided by developers and that might be staged for a runtime
+  deprecation in a future Node.js major release. An explicit notice indicating
+  the deprecation status is added to the API documentation but no functional
+  changes are implemented in the code. By default there will be no deprecation
+  warnings emitted for such deprecations at runtime. Documentation-only
+  deprecations may trigger a runtime warning when Node.js is started with the
+  [`--pending-deprecation`][] flag or the `NODE_PENDING_DEPRECATION=1`
+  environment variable is set.
 
 * *Runtime Deprecation* refers to the use of process warnings emitted at
   runtime the first time that a deprecated API is used. A command-line
@@ -489,8 +490,7 @@ The TSC should serve as the final arbiter where required.
 1. Never use GitHub's green ["Merge Pull Request"][] button. Reasons for not
    using the web interface button:
    * The merge method will add an unnecessary merge commit.
-   * The squash & merge method has been known to add metadata to the commit
-     title (the PR #).
+   * The squash & merge method can add metadata (the PR #) to the commit title.
    * If more than one author has contributed to the PR, keep the most recent
      author when squashing.
 1. Make sure the CI is done and the result is green. If the CI is not green,
@@ -832,7 +832,6 @@ LTS working group and the Release team.
 | Subsystem                                | Maintainers                                                           |
 | ---                                      | ---                                                                   |
 | `benchmark/*`                            | @nodejs/benchmarking, @mscdex                                         |
-| `bootstrap_node.js`                      | @nodejs/process                                                       |
 | `doc/*`, `*.md`                          | @nodejs/documentation                                                 |
 | `lib/assert`                             | @nodejs/testing                                                       |
 | `lib/async_hooks`                        | @nodejs/async\_hooks for bugs/reviews (+ @nodejs/diagnostics for API) |
@@ -845,20 +844,21 @@ LTS working group and the Release team.
 | `lib/fs`, `src/{fs,file}`                | @nodejs/fs                                                            |
 | `lib/{_}http{*}`                         | @nodejs/http                                                          |
 | `lib/inspector.js`, `src/inspector_*`    | @nodejs/V8-inspector                                                  |
+| `lib/internal/bootstrap/*`               | @nodejs/process                                                       |
 | `lib/internal/url`, `src/node_url`       | @nodejs/url                                                           |
 | `lib/net`                                | @bnoordhuis, @indutny, @nodejs/streams                                |
 | `lib/repl`                               | @nodejs/repl                                                          |
 | `lib/{_}stream{*}`                       | @nodejs/streams                                                       |
 | `lib/timers`                             | @nodejs/timers                                                        |
 | `lib/util`                               | @nodejs/util                                                          |
 | `lib/zlib`                               | @nodejs/zlib                                                          |
-| `src/async-wrap.*`                       | @nodejs/async\_hooks                                                  |
+| `src/async_wrap.*`                       | @nodejs/async\_hooks                                                  |
 | `src/node_api.*`                         | @nodejs/n-api                                                         |
 | `src/node_crypto.*`                      | @nodejs/crypto                                                        |
 | `test/*`                                 | @nodejs/testing                                                       |
 | `tools/node_modules/eslint`, `.eslintrc` | @nodejs/linting                                                       |
 | build                                    | @nodejs/build                                                         |
-| `src/module_wrap.*`, `lib/internal/loader/*`, `lib/internal/vm/Module.js` | @nodejs/modules                      |
+| `src/module_wrap.*`, `lib/internal/modules/*`, `lib/internal/vm/module.js` | @nodejs/modules                     |
 | GYP                                      | @nodejs/gyp                                                           |
 | performance                              | @nodejs/performance                                                   |
 | platform specific                        | @nodejs/platform-{aix,arm,freebsd,macos,ppc,smartos,s390,windows}     |

CPP_STYLE_GUIDE.md

@@ -12,6 +12,7 @@
   * [CamelCase for methods, functions, and classes](#camelcase-for-methods-functions-and-classes)
   * [snake\_case for local variables and parameters](#snake_case-for-local-variables-and-parameters)
   * [snake\_case\_ for private class fields](#snake_case_-for-private-class-fields)
+  * [snake\_case\_ for C-like structs](#snake_case_-for-c-like-structs)
   * [Space after `template`](#space-after-template)
 * [Memory Management](#memory-management)
   * [Memory allocation](#memory-allocation)
@@ -147,6 +148,15 @@ class Foo {
 };
 ```
 
+## snake\_case\_ for C-like structs
+For plain C-like structs snake_case can be used.
+
+```c++
+struct foo_bar {
+  int name;
+}
+```
+
 ## Space after `template`
 
 ```c++

Makefile

@@ -393,7 +393,7 @@ clear-stalled:
 	ps awwx | grep Release/node | grep -v grep | cat
 	@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
 	if [ "$${PS_OUT}" ]; then \
-		echo $${PS_OUT} | xargs kill; \
+		echo $${PS_OUT} | xargs kill -9; \
 	fi
 
 .PHONY: test-gc
@@ -439,7 +439,7 @@ test-ci-js: | clear-stalled
 	ps awwx | grep Release/node | grep -v grep | cat
 	@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
 	if [ "$${PS_OUT}" ]; then \
-		echo $${PS_OUT} | xargs kill; exit 1; \
+		echo $${PS_OUT} | xargs kill -9; exit 1; \
 	fi
 
 .PHONY: test-ci
@@ -454,7 +454,7 @@ test-ci: | clear-stalled build-addons build-addons-napi doc-only
 	ps awwx | grep Release/node | grep -v grep | cat
 	@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
 	if [ "$${PS_OUT}" ]; then \
-		echo $${PS_OUT} | xargs kill; exit 1; \
+		echo $${PS_OUT} | xargs kill -9; exit 1; \
 	fi
 
 .PHONY: build-ci
@@ -652,7 +652,7 @@ tools/doc/node_modules/js-yaml/package.json:
 
 gen-json = tools/doc/generate.js --format=json $< > $@
 gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html \
-			--template=doc/template.html --analytics=$(DOCS_ANALYTICS) $< > $@
+			--analytics=$(DOCS_ANALYTICS) $< > $@
 
 out/doc/api/%.json: doc/api/%.md
 	$(call available-node, $(gen-json))
@@ -813,8 +813,8 @@ release-only:
 		exit 1 ; \
 	fi
 	@if [ "$(DISTTYPE)" != "nightly" ] && [ "$(DISTTYPE)" != "next-nightly" ] && \
-		`grep -q DEP00XX doc/api/deprecations.md`; then \
-		echo 'Please update DEP00XX in doc/api/deprecations.md (See doc/releases.md)' ; \
+		`grep -q DEP...X doc/api/deprecations.md`; then \
+		echo 'Please update DEP...X in doc/api/deprecations.md (See doc/releases.md)' ; \
 		exit 1 ; \
 	fi
 	@if [ "$(shell git status --porcelain | egrep -v '^\?\? ')" = "" ]; then \

README.md

@@ -55,6 +55,8 @@ search these unofficial resources:
 * [Questions tagged 'node.js' on StackOverflow][]
 * [#node.js channel on chat.freenode.net][]. See <http://nodeirc.info/> for more
   information.
+* [Node.js Slack Community](https://node-js.slack.com/): Visit
+  [nodeslackers.com](http://www.nodeslackers.com/) to register.
 
 GitHub issues are meant for tracking enhancements and bugs, not general support.
 
@@ -512,8 +514,6 @@ For more information about the governance of the Node.js project, see
 **Trivikram Kamat** &lt;trivikr.dev@gmail.com&gt;
 * [Trott](https://github.com/Trott) -
 **Rich Trott** &lt;rtrott@gmail.com&gt; (he/him)
-* [tunniclm](https://github.com/tunniclm) -
-**Mike Tunnicliffe** &lt;m.j.tunnicliffe@gmail.com&gt;
 * [vdeturckheim](https://github.com/vdeturckheim) -
 **Vladimir de Turckheim** &lt;vlad2t@hotmail.com&gt; (he/him)
 * [vkurchatkin](https://github.com/vkurchatkin) -
@@ -557,6 +557,8 @@ For more information about the governance of the Node.js project, see
 **Alex Kocharin** &lt;alex@kocharin.ru&gt;
 * [tellnes](https://github.com/tellnes) -
 **Christian Tellnes** &lt;christian@tellnes.no&gt;
+* [tunniclm](https://github.com/tunniclm) -
+**Mike Tunnicliffe** &lt;m.j.tunnicliffe@gmail.com&gt;
 
 Collaborators follow the [COLLABORATOR_GUIDE.md](./COLLABORATOR_GUIDE.md) in
 maintaining the Node.js project.

benchmark/events/ee-add-remove.js

@@ -2,7 +2,7 @@
 const common = require('../common.js');
 const events = require('events');
 
-const bench = common.createBenchmark(main, { n: [25e4] });
+const bench = common.createBenchmark(main, { n: [1e6] });
 
 function main({ n }) {
   const ee = new events.EventEmitter();

benchmark/fs/bench-stat-promise.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const common = require('../common');
-const fsPromises = require('fs/promises');
+const fsPromises = require('fs').promises;
 
 const bench = common.createBenchmark(main, {
   n: [20e4],

benchmark/http/headers.js

@@ -0,0 +1,36 @@
+'use strict';
+
+const common = require('../common.js');
+const http = require('http');
+
+const bench = common.createBenchmark(main, {
+  duplicates: [1, 100],
+  n: [10, 1000],
+});
+
+function main({ duplicates, n }) {
+  const headers = {
+    'Connection': 'keep-alive',
+    'Transfer-Encoding': 'chunked',
+  };
+
+  for (var i = 0; i < n / duplicates; i++) {
+    headers[`foo${i}`] = [];
+    for (var j = 0; j < duplicates; j++) {
+      headers[`foo${i}`].push(`some header value ${i}`);
+    }
+  }
+
+  const server = http.createServer(function(req, res) {
+    res.writeHead(200, headers);
+    res.end();
+  });
+  server.listen(common.PORT, function() {
+    bench.http({
+      path: '/',
+      connections: 10
+    }, function() {
+      server.close();
+    });
+  });
+}

benchmark/process/next-tick-depth-args.js

@@ -8,52 +8,53 @@ const bench = common.createBenchmark(main, {
 process.maxTickDepth = Infinity;
 
 function main({ n }) {
+  let counter = n;
   function cb4(arg1, arg2, arg3, arg4) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb3(arg1, arg2, arg3) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb2(arg1, arg2) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);
     } else
       bench.end(n);
   }
   function cb1(arg1) {
-    if (--n) {
-      if (n % 4 === 0)
+    if (--counter) {
+      if (counter % 4 === 0)
         process.nextTick(cb4, 3.14, 1024, true, false);
-      else if (n % 3 === 0)
+      else if (counter % 3 === 0)
         process.nextTick(cb3, 512, true, null);
-      else if (n % 2 === 0)
+      else if (counter % 2 === 0)
         process.nextTick(cb2, false, 5.1);
       else
         process.nextTick(cb1, 0);

benchmark/process/next-tick-depth.js

@@ -7,11 +7,11 @@ const bench = common.createBenchmark(main, {
 process.maxTickDepth = Infinity;
 
 function main({ n }) {
-
+  let counter = n;
   bench.start();
   process.nextTick(onNextTick);
   function onNextTick() {
-    if (--n)
+    if (--counter)
       process.nextTick(onNextTick);
     else
       bench.end(n);

benchmark/process/next-tick-exec-args.js

@@ -5,8 +5,11 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n }) {
+  function onNextTick(i) {
+    if (i + 1 === n)
+      bench.end(n);
+  }
 
-  bench.start();
   for (var i = 0; i < n; i++) {
     if (i % 4 === 0)
       process.nextTick(onNextTick, i, true, 10, 'test');
@@ -17,8 +20,6 @@ function main({ n }) {
     else
       process.nextTick(onNextTick, i);
   }
-  function onNextTick(i) {
-    if (i + 1 === n)
-      bench.end(n);
-  }
+
+  bench.start();
 }

benchmark/process/next-tick-exec.js

@@ -5,13 +5,14 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n }) {
-
-  bench.start();
-  for (var i = 0; i < n; i++) {
-    process.nextTick(onNextTick, i);
-  }
   function onNextTick(i) {
     if (i + 1 === n)
       bench.end(n);
   }
+
+  for (var i = 0; i < n; i++) {
+    process.nextTick(onNextTick, i);
+  }
+
+  bench.start();
 }

benchmark/util/splice-one.js

@@ -0,0 +1,33 @@
+'use strict';
+
+const common = require('../common');
+
+const bench = common.createBenchmark(main, {
+  n: [1e7],
+  pos: ['start', 'middle', 'end'],
+  size: [10, 100, 500],
+}, { flags: ['--expose-internals'] });
+
+function main({ n, pos, size }) {
+  const { spliceOne } = require('internal/util');
+  const arr = new Array(size);
+  arr.fill('');
+  let index;
+  switch (pos) {
+    case 'end':
+      index = size - 1;
+      break;
+    case 'middle':
+      index = Math.floor(size / 2);
+      break;
+    default: // start
+      index = 0;
+  }
+
+  bench.start();
+  for (var i = 0; i < n; i++) {
+    spliceOne(arr, index);
+    arr.push('');
+  }
+  bench.end(n);
+}