Fixdoc1 #20641
Closed
Fixdoc1 #20641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like we missed updating doc when we changed from NODE_EXTERN to NAPI_EXTERN
nodejs-github-bot
added
doc
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
fast-track
addaleax
approved these changes
May 9, 2018
vsemozhetbyt
added
the
author ready
jasnell
approved these changes
May 9, 2018
|
Could we address this tiny issue #20645 in this PR ? They are pretty related. |
cjihrig
approved these changes
May 10, 2018
|
@LEQADA I'd prefer to do that in a separate PR as 6.x is still experimental and may be for a while. Doing it in a separate PR will avoid issues with backporting the changes in the PR. |
|
@LEQADA submitted a separate PR to fix. |
trivikr
approved these changes
May 11, 2018
BridgeAR
approved these changes
May 13, 2018
|
Landed in 1248ce1...2e4ee3d |
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
Seems like we missed updating doc when we changed from NODE_EXTERN to NAPI_EXTERN PR-URL: #20641 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
May 14, 2018
Seems like we missed updating doc when we changed from NODE_EXTERN to NAPI_EXTERN PR-URL: #20641 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes