Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update AUTHORS list #20658

Closed
wants to merge 1 commit into from
Closed

doc: update AUTHORS list #20658

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 10, 2018

No description provided.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 10, 2018
BridgeAR
BridgeAR approved these changes May 10, 2018
View reviewed changes
AUTHORS
Yichao 'Peak' Ji <peakji@users.noreply.github.com>
Jesse W. Collins <jesse.w.collins@gmail.com>
TSUYUSATO Kitsune <make.just.on@gmail.com>
daGo <daniel1kdago@gmail.com>
Copy link
Member

@BridgeAR BridgeAR May 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dagobert Michelsen

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong account. See #20537

mhdawson
mhdawson approved these changes May 10, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 10, 2018
@addaleax addaleax removed the fast-track PRs that do not need to wait for 48 hours to land. label May 11, 2018
targos added a commit to targos/node that referenced this pull request May 13, 2018
@targos
doc: update AUTHORS list
6de0f55 
PR-URL: nodejs#20658
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented May 13, 2018

Landed in 6de0f55

@targos targos closed this May 13, 2018
@targos targos deleted the update-authors branch May 13, 2018 07:23
addaleax pushed a commit that referenced this pull request May 14, 2018
@targos @addaleax
doc: update AUTHORS list
512982c 
PR-URL: #20658
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@devsnek devsnek devsnek approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @danbev @jasnell @cjihrig @devsnek @BridgeAR @mhdawson @trivikr @addaleax @nodejs-github-bot