Fix http status codes #20700
Closed
Fix http status codes #20700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the message to be consistent with RFC 7168, and the rest of the statuses.
apapirovski
requested changes
May 13, 2018
There was a problem hiding this comment.
Actually, sorry, looks like Multiple Choices is still correct as per https://tools.ietf.org/html/rfc7231#section-6.4.1
Perhaps change it back and adjust the comment to point to RFC7231 so this doesn't come up in the future?
aduh95
force-pushed
the
fix_http_status_codes
branch
from
bd71414
to
155efdf
Compare
|
The JS linter doesn’t pass, I need to rephrase my comment. I’m taking care of that later today! EDIT: Done. |
aduh95
force-pushed
the
fix_http_status_codes
branch
from
155efdf
to
01c089f
Compare
Adding comments to reference which RFC Node.js is following. Refs: https://tools.ietf.org/html/rfc7231#section-6.4.1 Refs: https://tools.ietf.org/html/rfc7168#section-2.3.3
BridgeAR
approved these changes
May 18, 2018
|
What is this semver wise? 😄 |
That would be major right? I mean, we certainly wouldn't risk to break all the coffee pot controlling installations out there, would we? Those people deserve their coffee, even if they use an old version of the spec! 😄 |
trivikr
approved these changes
May 19, 2018
jasnell
approved these changes
May 19, 2018
cjihrig
approved these changes
May 19, 2018
hiroppy
approved these changes
May 20, 2018
apapirovski
approved these changes
May 22, 2018
apapirovski
pushed a commit
that referenced
this pull request
May 22, 2018
Update the message to be consistent with RFC 7168. Add a note to "Multiple Choices" regarding RFC 7231 superseding RFC 7168. PR-URL: #20700 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>t Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Landed in 464852b @mvasilkov and @aduh95 you should both be Contributors now! Thanks for the contribution. |
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Update the message to be consistent with RFC 7168. Add a note to "Multiple Choices" regarding RFC 7231 superseding RFC 7168. PR-URL: #20700 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>t Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 23, 2018
Update the message to be consistent with RFC 7168. Add a note to "Multiple Choices" regarding RFC 7231 superseding RFC 7168. PR-URL: #20700 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me>t Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20286.
I have used the @mvasilkov 's patch and @mithunsasidharan 's advice to make Node.js compliant with the latest HTCPCP-TEA (RFC 7168, an extension to HTCPCP to allow for pots to provide networked tea-brewing facilities).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes