doc: reorder CODEOWNERS file #20732
Closed
doc: reorder CODEOWNERS file #20732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Later rules take precedence over earlier rules, so move all rules that assign ownership to TSC to the end of the file. There are likely other reorderings that we will want to consider.
nodejs-github-bot
added
the
meta
vsemozhetbyt
approved these changes
May 15, 2018
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
jasnell
approved these changes
May 15, 2018
|
This is going to need a lot of iterations to get exactly correct. |
vsemozhetbyt
added
fast-track
trivikr
approved these changes
May 15, 2018
Yup, but you knew that when you created it. :-D (Thanks for doing it, by the way.) |
cjihrig
approved these changes
May 15, 2018
danbev
approved these changes
May 15, 2018
targos
approved these changes
May 15, 2018
lpinca
approved these changes
May 15, 2018
BridgeAR
approved these changes
May 15, 2018
|
Landed in 8c1186d |
apapirovski
pushed a commit
that referenced
this pull request
May 16, 2018
Later rules take precedence over earlier rules, so move all rules that assign ownership to TSC to the end of the file. There are likely other reorderings that we will want to consider. PR-URL: #20732 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Later rules take precedence over earlier rules, so move all rules that assign ownership to TSC to the end of the file. There are likely other reorderings that we will want to consider. PR-URL: #20732 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Later rules take precedence over earlier rules, so move all rules that
assign ownership to TSC to the end of the file. There are likely other
reorderings that we will want to consider.
Checklist
@vsemozhetbyt