Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: minor style improvements to crypto.cc #20799

Closed
wants to merge 2 commits into from
Closed

crypto: minor style improvements to crypto.cc #20799

wants to merge 2 commits into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented May 17, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
src: use unqualified names in node_crypto.cc
7c5873c 
This commit removes the usage of qualified names for consistency.
@danbev
src: make pointers lean left in node_crypto.cc
8e49ba0
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels May 17, 2018
@danbev
Copy link
Contributor Author

danbev commented May 17, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14924/

@mscdex
Copy link
Contributor

mscdex commented May 17, 2018

Is it possible to add any of these to the C++ linter?

@danbev
Copy link
Contributor Author

danbev commented May 17, 2018

Is it possible to add any of these to the C++ linter?

I've made an attempt to for the leaning pointers but there are a lot of cases that can match this. I'll try again once I have a little more time.

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2018
tniessen pushed a commit that referenced this pull request May 20, 2018
@danbev @tniessen
src: use unqualified names in node_crypto.cc
6f34056 
This commit removes the usage of qualified names for consistency.

PR-URL: #20799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
tniessen pushed a commit that referenced this pull request May 20, 2018
@danbev @tniessen
src: make pointers lean left in node_crypto.cc
a0eb1e4 
PR-URL: #20799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@tniessen
Copy link
Member

Failure on ARM is unrelated, landed in 6f34056, a0eb1e4.

@tniessen tniessen closed this May 20, 2018
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@danbev @MylesBorins
src: use unqualified names in node_crypto.cc
b622534 
This commit removes the usage of qualified names for consistency.

PR-URL: #20799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@danbev @MylesBorins
src: make pointers lean left in node_crypto.cc
3110d15 
PR-URL: #20799
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
@danbev danbev deleted the crypto_minor_style_improvements branch August 20, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @mscdex @tniessen @jasnell @lpinca @cjihrig @trivikr @BridgeAR @nodejs-github-bot