build: always use prefix=/ for tar-headers #2082
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll also land this on master at the same time, the interim fix is to add |
|
LGTM but can you use capitalization and punctuation in the body of the commit log? I don't understand the 'how headers files should be formatted' comment. Did you mean s/formatted/installed/? |
|
I'm not a big fan about the inconsistency between the installs, but I fail to see when users will call this. Also, this (in my mind) is a temporary step even if it lives for a year. LGTM |
|
@bnoordhuis thanks for proofing the commit msg as always, very appreciated. PTAL, current one is: Does that make more sense? |
rvagg
added a commit
that referenced
this pull request
Jul 15, 2015
Defaults to /usr/local otherwise, which isn't helpful for node-gyp, nor standard assumptions about how header directories should be structured. PR-URL: #2082 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg
force-pushed
the
fix-headers-prefix
branch
from
e236dc7
to
f95f9ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaults to /usr/local otherwise which isn't helpful for node-gyp, nor standard assumptions about how headers files should be formatted
discovered this fault in our nightly headers tarballs
/R=@nodejs/build