Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in http2.md #20843

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in http2.md #20843

wants to merge 1 commit into from

Conversation

kakts
Copy link
Contributor

@kakts kakts commented May 20, 2018

Summary

I fixed typo in http2.md

Http2ServerRespose → Http2ServerResponse

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 20, 2018
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2018
@trivikr
Copy link
Member

trivikr commented May 20, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/733/

@trivikr
Copy link
Member

trivikr commented May 20, 2018

Node.js Collaborators, please add 👍 here if you approve fast-tracking.

@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label May 20, 2018
@vsemozhetbyt
Copy link
Contributor

Landed in 0271b0f
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request May 20, 2018
@kakts @vsemozhetbyt
doc: fix typo in http2.md
0271b0f 
PR-URL: #20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@kakts @MylesBorins
doc: fix typo in http2.md
37b9fe1 
PR-URL: #20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleax addaleax mentioned this pull request May 22, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@kakts @kjin
doc: fix typo in http2.md
3dc4951 
PR-URL: nodejs#20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
kjin pushed a commit to kjin/node that referenced this pull request Sep 25, 2018
@kakts @kjin
doc: fix typo in http2.md
5635eae 
PR-URL: nodejs#20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@kakts @kjin
doc: fix typo in http2.md
4ef2393 
PR-URL: nodejs#20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@kakts @BethGriggs
doc: fix typo in http2.md
11a63dd 
Backport-PR-URL: #22850
PR-URL: #20843
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kakts @trivikr @vsemozhetbyt @lpinca @cjihrig @tniessen @nodejs-github-bot