Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix HTTP req/res 'close' description #21047

Closed
wants to merge 1 commit into from
Closed

docs: fix HTTP req/res 'close' description #21047

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented May 30, 2018

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 30, 2018
@ronag ronag mentioned this pull request May 31, 2018
Closed
@mscdex mscdex mentioned this pull request May 31, 2018
Closed
@trivikr
Copy link
Member

trivikr commented Jun 4, 2018

cc @nodejs/http

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2018
@targos
Copy link
Member

targos commented Jun 24, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/891/

@trivikr
Copy link
Member

trivikr commented Jun 24, 2018

Landed in 8ab7ea6

@trivikr trivikr closed this Jun 24, 2018
trivikr pushed a commit that referenced this pull request Jun 24, 2018
@ronag @trivikr
doc: fix HTTP req/res 'close' description
8ab7ea6 
PR-URL: #21047
Reviewed-By: James M Snell <jasnell@gmail.com>
@devsnek
Copy link
Member

devsnek commented Jun 24, 2018

this should have had one more approval right? (not saying it needs to be reverted or anything)

@vsemozhetbyt
Copy link
Contributor

In order to land, a Pull Request needs to be reviewed and approved by at least one Node.js Collaborator and pass a CI (Continuous Integration) test run.

https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#step-10-landing

@vsemozhetbyt
Copy link
Contributor

We need 2 approval for fast-track though (not this case):

The pull request can be landed once 2 or more Collaborators approve both the pull request and the fast-tracking request, and the necessary CI testing is done.

https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#waiting-for-approvals

targos pushed a commit that referenced this pull request Jun 24, 2018
@ronag @targos
doc: fix HTTP req/res 'close' description
2359823 
PR-URL: #21047
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
@tadjik1 tadjik1 mentioned this pull request Jul 5, 2018
Closed
2 tasks
@msmol msmol mentioned this pull request Jul 8, 2018
Merged
@mcollina mcollina mentioned this pull request Jul 18, 2018
Closed
2 tasks
@targos targos added dont-land-on-v6.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ronag @trivikr @targos @devsnek @vsemozhetbyt @jasnell @nodejs-github-bot