Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream,doc: require finished callback and add options docs #21058

Closed
wants to merge 3 commits into from
Closed

stream,doc: require finished callback and add options docs #21058

wants to merge 3 commits into from

Commits on Aug 20, 2018

  1. lib: require a callback for end-of-stream 

    Make the callback mandatory as mostly done in all other Node.js
callback APIs so users explicitly have to decide what to do in error
cases.
    @BridgeAR
    BridgeAR committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    3d893b9 View commit details
    Browse the repository at this point in the history

  2. doc: add options documentation to Stream.finished() 

    When originally implemented it was missed that Stream.finished() has
an optional options object. This adds the docs to those.
    @BridgeAR
    BridgeAR committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    48b32f9 View commit details
    Browse the repository at this point in the history

  3. fixup: address comments & add tests

    @BridgeAR
    BridgeAR committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    c310236 View commit details
    Browse the repository at this point in the history