-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large Page Support for Code Issue: 16198 #21064
Changes from all commits
0a76c7e
fa0e324
fdb45cd
b7791c2
6631eea
843089c
077bc01
7bdd9fc
b91de5a
7ef956a
b02e7a9
2af82b1
cae9285
30114b6
39e1f0d
49cd0de
2dd9e8c
51d0f02
2f672ee
31504cc
f998c58
9f15cfc
d6de361
29c7d13
9828036
600cf54
bf259e2
f0a6dcb
4610793
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
SECTIONS { | ||
.lpstub : { *(.lpstub) } | ||
} | ||
PROVIDE (__nodetext = .); | ||
PROVIDE (_nodetext = .); | ||
PROVIDE (nodetext = .); | ||
INSERT BEFORE .text; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,258 @@ | ||
// Copyright (C) 2018 Intel Corporation | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), | ||
// to deal in the Software without restriction, including without limitation | ||
// the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
// and/or sell copies of the Software, and to permit persons to whom | ||
// the Software is furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included | ||
// in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES | ||
// OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, | ||
// ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE | ||
// OR OTHER DEALINGS IN THE SOFTWARE. | ||
// | ||
// SPDX-License-Identifier: MIT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment in here pointing back to it's original source? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Fishrock123 I dont fully understand the comment. Pointing back to the SPDX url? |
||
|
||
#include <errno.h> | ||
#include <fcntl.h> // _O_RDWR | ||
#include <limits.h> // PATH_MAX | ||
#include <locale.h> | ||
#include <signal.h> | ||
#include <stdio.h> | ||
#include <stdlib.h> | ||
#include <stdint.h> | ||
#include <string.h> | ||
#include <sys/types.h> | ||
#include <sys/mman.h> | ||
|
||
#include <string> | ||
#include <fstream> | ||
#include <iostream> | ||
#include <sstream> | ||
|
||
// The functions in this file map the text segment of node into 2M pages. | ||
// The algorithm is simple | ||
// 1. Find the text region of node binary in memory | ||
// Examine the /proc/self/maps to determine the currently mapped text | ||
// region and obtain the start and end | ||
// Modify the start to point to the very beginning of node text segment | ||
// (from variable nodetext setup in ld.script) | ||
// Align the address of start and end to Large Page Boundaries | ||
// | ||
// 2. Move the text region to large pages | ||
// Map a new area and copy the original code there | ||
// Use mmap using the start address with MAP_FIXED so we get exactly the | ||
// same virtual address | ||
// Use madvise with MADV_HUGE_PAGE to use Anonymous 2M Pages | ||
// If successful copy the code there and unmap the original region. | ||
|
||
extern char __executable_start; | ||
extern char __etext; | ||
extern char __nodetext; | ||
|
||
namespace node { | ||
|
||
struct text_region { | ||
char* from; | ||
char* to; | ||
int total_hugepages; | ||
bool found_text_region; | ||
}; | ||
|
||
static void PrintSystemError(int error) { | ||
fprintf(stderr, "Hugepages WARNING: %s\n", strerror(error)); | ||
return; | ||
} | ||
|
||
inline int64_t hugepage_align_up(int64_t addr) { | ||
const size_t hps = 2L * 1024 * 1024; | ||
return (((addr) + (hps) - 1) & ~((hps) - 1)); | ||
} | ||
inline int64_t hugepage_align_down(int64_t addr) { | ||
const size_t hps = 2L * 1024 * 1024; | ||
return ((addr) & ~((hps) - 1)); | ||
} | ||
// The format of the maps file is the following | ||
// address perms offset dev inode pathname | ||
// 00400000-00452000 r-xp 00000000 08:02 173521 /usr/bin/dbus-daemon | ||
|
||
static struct text_region FindNodeTextRegion() { | ||
std::ifstream ifs; | ||
std::string map_line; | ||
std::string permission; | ||
char dash; | ||
int64_t start, end; | ||
const size_t hps = 2L * 1024 * 1024; | ||
struct text_region nregion; | ||
|
||
nregion.found_text_region = false; | ||
|
||
ifs.open("/proc/self/maps"); | ||
if (!ifs) { | ||
fprintf(stderr, "Could not open /proc/self/maps\n"); | ||
return nregion; | ||
} | ||
std::getline(ifs, map_line); | ||
std::istringstream iss(map_line); | ||
ifs.close(); | ||
|
||
iss >> std::hex >> start; | ||
iss >> dash; | ||
iss >> std::hex >> end; | ||
iss >> permission; | ||
|
||
if (permission.compare("r-xp") == 0) { | ||
start = reinterpret_cast<unsigned int64_t>(&__nodetext); | ||
char* from = reinterpret_cast<char* >(hugepage_align_up(start)); | ||
char* to = reinterpret_cast<char* >(hugepage_align_down(end)); | ||
|
||
if (from < to) { | ||
size_t size = to - from; | ||
nregion.found_text_region = true; | ||
nregion.from = from; | ||
nregion.to = to; | ||
nregion.total_hugepages = size / hps; | ||
} | ||
} | ||
|
||
return nregion; | ||
} | ||
|
||
static bool IsTransparentHugePagesEnabled() { | ||
std::ifstream ifs; | ||
|
||
ifs.open("/sys/kernel/mm/transparent_hugepage/enabled"); | ||
if (!ifs) { | ||
fprintf(stderr, "Could not open file: " \ | ||
"/sys/kernel/mm/transparent_hugepage/enabled\n"); | ||
return false; | ||
} | ||
|
||
std::string always, madvise, never; | ||
if (ifs.is_open()) { | ||
while (ifs >> always >> madvise >> never) {} | ||
} | ||
|
||
int ret_status = false; | ||
|
||
if (always.compare("[always]") == 0) | ||
ret_status = true; | ||
else if (madvise.compare("[madvise]") == 0) | ||
ret_status = true; | ||
else if (never.compare("[never]") == 0) | ||
ret_status = false; | ||
|
||
ifs.close(); | ||
return ret_status; | ||
} | ||
|
||
// Moving the text region to large pages. We need to be very careful. | ||
// a) This function itself should not be moved. | ||
// We use a gcc option to put it outside the ".text" section | ||
// b) This function should not call any function(s) that might be moved. | ||
// 1. map a new area and copy the original code there | ||
// 2. mmap using the start address with MAP_FIXED so we get exactly | ||
// the same virtual address | ||
// 3. madvise with MADV_HUGE_PAGE | ||
// 3. If successful copy the code there and unmap the original region | ||
int | ||
__attribute__((__section__(".lpstub"))) | ||
__attribute__((__aligned__(2 * 1024 * 1024))) | ||
__attribute__((__noinline__)) | ||
__attribute__((__optimize__("2"))) | ||
MoveTextRegionToLargePages(struct text_region r) { | ||
void* nmem = nullptr; | ||
void* tmem = nullptr; | ||
int ret = 0; | ||
|
||
size_t size = r.to - r.from; | ||
void* start = r.from; | ||
|
||
// Allocate temporary region preparing for copy | ||
nmem = mmap(nullptr, size, | ||
PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); | ||
if (nmem == MAP_FAILED) { | ||
PrintSystemError(errno); | ||
return -1; | ||
} | ||
|
||
memcpy(nmem, r.from, size); | ||
|
||
// We already know the original page is r-xp | ||
// (PROT_READ, PROT_EXEC, MAP_PRIVATE) | ||
// We want PROT_WRITE because we are writing into it. | ||
// We want it at the fixed address and we use MAP_FIXED. | ||
tmem = mmap(start, size, | ||
PROT_READ | PROT_WRITE | PROT_EXEC, | ||
MAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1 , 0); | ||
if (tmem == MAP_FAILED) { | ||
PrintSystemError(errno); | ||
munmap(nmem, size); | ||
return -1; | ||
} | ||
|
||
ret = madvise(tmem, size, MADV_HUGEPAGE); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
ret = munmap(tmem, size); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
} | ||
ret = munmap(nmem, size); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
} | ||
|
||
return -1; | ||
} | ||
|
||
memcpy(start, nmem, size); | ||
ret = mprotect(start, size, PROT_READ | PROT_EXEC); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
ret = munmap(tmem, size); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
} | ||
ret = munmap(nmem, size); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
} | ||
return -1; | ||
} | ||
|
||
// Release the old/temporary mapped region | ||
ret = munmap(nmem, size); | ||
if (ret == -1) { | ||
PrintSystemError(errno); | ||
} | ||
|
||
return ret; | ||
} | ||
|
||
// This is the primary API called from main | ||
int MapStaticCodeToLargePages() { | ||
struct text_region r = FindNodeTextRegion(); | ||
if (r.found_text_region == false) { | ||
fprintf(stderr, "Hugepages WARNING: failed to find text region \n"); | ||
return -1; | ||
} | ||
|
||
if (r.from > reinterpret_cast<void* > (&MoveTextRegionToLargePages)) | ||
return MoveTextRegionToLargePages(r); | ||
|
||
return -1; | ||
} | ||
|
||
bool IsLargePagesEnabled() { | ||
return IsTransparentHugePagesEnabled(); | ||
} | ||
|
||
} // namespace node |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright (C) 2018 Intel Corporation | ||
// | ||
// Permission is hereby granted, free of charge, to any person obtaining a copy | ||
// of this software and associated documentation files (the "Software"), | ||
// to deal in the Software without restriction, including without limitation | ||
// the rights to use, copy, modify, merge, publish, distribute, sublicense, | ||
// and/or sell copies of the Software, and to permit persons to whom | ||
// the Software is furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be included | ||
// in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL | ||
// THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES | ||
// OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, | ||
// ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE | ||
// OR OTHER DEALINGS IN THE SOFTWARE. | ||
// | ||
// SPDX-License-Identifier: MIT | ||
|
||
#ifndef SRC_NODE_LARGE_PAGE_H_ | ||
#define SRC_NODE_LARGE_PAGE_H_ | ||
|
||
#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | ||
|
||
|
||
namespace node { | ||
bool IsLargePagesEnabled(); | ||
int MapStaticCodeToLargePages(); | ||
} // namespace node | ||
|
||
#endif // NODE_WANT_INTERNALS | ||
#endif // SRC_NODE_LARGE_PAGE_H_ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason why we are doing it here, as opposed to the very beginning of everything, in main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason. This was a place where other things were initialized like VTune support.