doc: add config for welcome bot #21074
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # https://github.com/behaviorbot/welcome | ||
| # combines new-issue-welcome, new-pr-welcome, and first-pr-merge | ||
|
|
||
| # Comment on first-time issues | ||
| # https://github.com/behaviorbot/new-issue-welcome | ||
| newIssueWelcomeComment: > | ||
| 👋 Thanks for opening your first issue here! If you're reporting a bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. | ||
|
|
||
| To make it easier for us to investigate your issue, please follow the [contributing guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/issues.md). | ||
|
|
||
| # Comment on PRs from first-time contributors | ||
| # https://github.com/behaviorbot/new-pr-welcome | ||
| newPRWelcomeComment: > | ||
| 💚 Thanks for opening this pull request! 💚 | ||
|
|
||
| Please make sure to update documentation and tests when appropriate, and follow the [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) | ||
|
|
||
| For non-trivial changes, pull requests must be left open for *at least* 48 hours during the week, and 72 hours on a weekend (in UTC time) before being merged. | ||
|
|
||
| If this pull request changes includes code changes, the CI must be started by a [collaborator](https://github.com/nodejs/node/blob/master/GOVERNANCE.md#collaborators). | ||
|
|
||
| We get a lot of pull requests on this repo, so please be patient and we will review this as soon as we can. | ||
|
|
||
| # Comment when a first-time contributor's PR is merged | ||
| # https://github.com/behaviorbot/first-pr-merge | ||
| firstPRMergeComment: > | ||
|
There was a problem hiding this comment. I think this can be removed since we rarely use the merge button and have our own workflow. It can be added when we adopt something else (e.g. a Jenkins job that merge the PR for us) There was a problem hiding this comment. Maybe we should leave it in for cases when the merge button is used? There was a problem hiding this comment. @zeke I am fine with leaving those texts. Although just for the sake of explanation, I am not actually aware of anybody using the button...at least not for first-time PRs. If you look at the PRs that are "merged", basically they are all opened and merged by collaborators, because right now if you don't use the merge button, you will need to push the HEAD that you are about to push to master to the same PR branch in order to make it purple. Unless you are the person that's going to push to master real soon, you are unlikely to get to the final state of that commit and push it to the PR branch right before it's pushed to master. https://github.com/nodejs/node/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged |
||
| Congratulations on merging your first pull request! 👍 | ||
|
There was a problem hiding this comment. Will this be triggered even if we don't merge the GitHub way? There was a problem hiding this comment. No, this app purely uses GitHub Apps to listen on webhook events, like the PR being closed and then checks if the PR was merged and if it was that individual's first PR to be merged. So it depends on GitHub's There was a problem hiding this comment. We often don't have that... |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to list common
wrong repocases here (e.g.npm,v8,node-gyp, .etc) but we can do that in a future PR.