[v8.x backport] n-api: take n-api out of experimental #21083
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take n-api out of experimental as per: nodejs/TSC#501 PR-URL: nodejs#19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
nodejs-github-bot
added
c++
3 tasks
jasnell
approved these changes
Jun 1, 2018
|
can you mention somewhere that it's a backport to 8.x? I was really confused seeing this. |
TimothyGu
approved these changes
Jun 1, 2018
lance
changed the title
lance
approved these changes
Jun 1, 2018
mhdawson
added
the
semver-minor
|
Looks like freeBSD is likely: #19311 Both of which are unrelated but one more CI run to be sure: https://ci.nodejs.org/job/node-test-pull-request/15313/ |
|
Sole failure in second CI run was known issue #18254. CI looks good going to land. |
mhdawson
added a commit
that referenced
this pull request
Jun 7, 2018
Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #21083 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
|
Landed as 084ef60 |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #21083 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
Take n-api out of experimental as per: nodejs/TSC#501 Backport-PR-URL: #21083 PR-URL: #19262 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take n-api out of experimental as per:
nodejs/TSC#501
PR-URL: #19262
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes