Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: fix request with option timeout and agent #21204

Closed
wants to merge 7 commits into from
Closed

http: fix request with option timeout and agent #21204

wants to merge 7 commits into from

Commits on Jun 8, 2018

  1. http: fix request with option timeout and agent 

    When request with both timeout and agent, timeout not
work. This patch will fix it, socket timeout will set
to request timeout before socket is connected, and
socket timeout will reset to agent timeout after
response end.

Update agent doc, add timeout option.

Fixes: nodejs#21185
    @killagu
    killagu committed Jun 8, 2018
    Configuration menu
    Copy the full SHA
    33e62a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2018

  1. update tests

    @killagu
    killagu committed Jun 11, 2018
    Configuration menu
    Copy the full SHA
    4add8f6 View commit details
    Browse the repository at this point in the history

  2. minor edit to doc text

    @Trott
    Trott authored Jun 11, 2018
    Configuration menu
    Copy the full SHA
    7ab62fb View commit details
    Browse the repository at this point in the history

  3. fixup! minor edit to comment text

    @Trott
    Trott authored Jun 11, 2018
    Configuration menu
    Copy the full SHA
    9773531 View commit details
    Browse the repository at this point in the history

  4. squash! minor edit to comment

    @Trott
    Trott authored Jun 11, 2018
    Configuration menu
    Copy the full SHA
    3b30906 View commit details
    Browse the repository at this point in the history

  5. squash! minor edits to comments

    @Trott
    Trott authored Jun 11, 2018
    Configuration menu
    Copy the full SHA
    1cf617e View commit details
    Browse the repository at this point in the history

  6. squash! minor edits to comments

    @Trott
    Trott authored Jun 11, 2018
    Configuration menu
    Copy the full SHA
    2c5f0c0 View commit details
    Browse the repository at this point in the history