deps: fix gypi sysroot settings on V8 #21494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
|
cc @targos @nodejs/v8 @nodejs/v8-update |
bnoordhuis
approved these changes
Jun 24, 2018
ofrobots
approved these changes
Jun 25, 2018
|
This is currently blocking |
richardlau
approved these changes
Jun 25, 2018
ryzokuken
approved these changes
Jun 25, 2018
|
CI: https://ci.nodejs.org/job/node-test-pull-request/15614/ Let's see if we can get a green before landing. |
mmarchini
force-pushed
the
fix-depot-tools-sysroot
branch
from
57c9461
to
fc45b16
Compare
|
Landed in fc45b16 |
mmarchini
pushed a commit
to mmarchini/node
that referenced
this pull request
Jun 25, 2018
On Node.js v8.x, gn will pass a sysroot parameter to clang to use a downloaded sysroot files while running `make test-v8`. Recently, chromium build tools switched to use Debian sid sysroot files instead of Debian jessie. This patch updates our V8 GYP files to conform with those changes. Ref: nodejs#21433 PR-URL: nodejs#21494 Refs: nodejs#21433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
marked as don't land for 6.x and 8.x... assuming that is the case based on the commit message. Please update if incorrect @mmarchini |
targos
pushed a commit
that referenced
this pull request
Jun 26, 2018
On Node.js v8.x, gn will pass a sysroot parameter to clang to use a downloaded sysroot files while running `make test-v8`. Recently, chromium build tools switched to use Debian sid sysroot files instead of Debian jessie. This patch updates our V8 GYP files to conform with those changes. Ref: #21433 PR-URL: #21494 Refs: #21433 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Node.js v8.x, gn will pass a sysroot parameter to clang to use a
downloaded sysroot files while running
make test-v8. Recently,chromium build tools switched to use Debian sid sysroot files instead of
Debian jessie. This patch updates our V8 GYP files to conform with those
changes.
Ref: #21433
make -j4 test(UNIX), orvcbuild test(Windows) passes