Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add inspect suffix to BigInt64Array elements #21499

Closed
wants to merge 3 commits into from
Closed

util: add inspect suffix to BigInt64Array elements #21499

wants to merge 3 commits into from

Commits on Jun 24, 2018

  1. util: add inspect suffix to BigInt64Array elements 

    This commit updates `util.inspect` to add an `n` suffix to BigInts that
appear in BigInt64Arrays. BigInts are formatted with an `n` suffix in
most cases, but this did not occur in BigInt64Arrays due to an apparent
oversight where the implementation of `inspect` for typed arrays assumed
that all typed array elements are numbers.
    @not-an-aardvark
    not-an-aardvark committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    7e000dc View commit details
    Browse the repository at this point in the history

  2. squash: use typeof for array type check

    @not-an-aardvark
    not-an-aardvark committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    2852b81 View commit details
    Browse the repository at this point in the history

  3. squash: avoid out-of-bounds reads

    @not-an-aardvark
    not-an-aardvark committed Jun 24, 2018
    Configuration menu
    Copy the full SHA
    5be5bfd View commit details
    Browse the repository at this point in the history