Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for missing dynamic instantiate hook #21506

Closed
wants to merge 1 commit into from
Closed

test: add test for missing dynamic instantiate hook #21506

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 24, 2018 •
edited
Loading

Depends on:
#21352
#21493

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@targos targos added test Issues and PRs related to the tests. blocked PRs that are blocked by other issues or PRs. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jun 24, 2018
@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/144/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 24, 2018
@targos targos added the wip Issues and PRs that are still a work in progress. label Jun 24, 2018
benjamingr
benjamingr approved these changes Jun 24, 2018
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given the other two land

@targos
Copy link
Member Author

targos commented Jun 30, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/15694/
Edit: new Linux run: https://ci.nodejs.org/job/node-test-commit-linux/19892/

@targos
Copy link
Member Author

targos commented Jul 3, 2018

Landed in 908518d

@targos targos closed this Jul 3, 2018
@targos targos deleted the test-add-esm-missing-dyn branch July 3, 2018 15:34
@targos targos removed wip Issues and PRs that are still a work in progress. blocked PRs that are blocked by other issues or PRs. labels Jul 3, 2018
targos added a commit that referenced this pull request Jul 3, 2018
@targos
test: add test for missing dynamic instantiate hook
908518d 
PR-URL: #21506
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
targos added a commit that referenced this pull request Jul 4, 2018
@targos
test: add test for missing dynamic instantiate hook
9cd5c0e 
PR-URL: #21506
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
@targos targos mentioned this pull request Jul 17, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@benjamingr benjamingr benjamingr approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @jasnell @benjamingr @devsnek