doc: add policy for landing new npm releases #21594
Conversation
doc/guides/maintaining-npm.md
Outdated
| @@ -1,5 +1,11 @@ | |||
| # Maintaining npm in Node.js | |||
|
|
|||
| New pull requests should be opened when a "next" release has been released. | |||
|
|
|||
| Once the "next" release has been promoted to "latest" the PR should be updated as neccessary | |||
There was a problem hiding this comment.
Nits:
- neccessary -> necessary
- Missing period.
- Wrapping this and the next line at 80 chars.
vsemozhetbyt
added
the
npm
|
I'm gonna hold off on discussing this until Rebecca's back from PTO next week, but I'm enthusiastic about node having a more official policy about how we handle npm updates. |
I think this should be made clear in the document as well. |
|
This seems fine. I'm not sure if you'll want to have a policy on hotfixes/regressions, but otherwise the timing's pretty much up to y'all. |
This change in policy sets clear terms for when / how npm releases can be landed into master and how long they are expected to bake in the ecosystem. This is to cover all release types of npm including semver-major releases. What Node.js releases the updates land into are at the discretion of the release team.
|
Updated all the things. PTAL |
|
As @zkat says, npm is happy to go along with whatever seems best for the Node.js project. With my Node.js contributor hat on, this seems quite reasonable and feels to me like a comfortable margin to assess the safety of updates. |
|
@nodejs/collaborators @nodejs/tsc @nodejs/npm I plan to land this in 24 hours if there are no objections |
| assuming no major regressions are found. There are no additional constraints | ||
| for Semver-Major releases. | ||
|
|
||
| The specific Node.js release stream the new version will be able to land into |
There was a problem hiding this comment.
grammar nit: release streams … are?
|
Landed in 7570ad5 fixing above nit |
This change in policy sets clear terms for when / how npm releases can be landed into master and how long they are expected to bake in the ecosystem. This is to cover all release types of npm including semver-major releases. What Node.js releases the updates land into are at the discretion of the release team. PR-URL: #21594 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This change in policy sets clear terms for when / how npm releases can be landed into master and how long they are expected to bake in the ecosystem. This is to cover all release types of npm including semver-major releases. What Node.js releases the updates land into are at the discretion of the release team. PR-URL: #21594 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
This change in policy sets clear terms for when / how npm releases
can be landed into master and how long they are expected to bake in the
ecosystem. This is to cover all release types of npm including semver-major
releases.
What Node.js release streams the new version of npm land into are at the discretion of the
release team and not specified by this policy.
I would like to ensure that we have consensus in landing this from @nodejs/collaborators @nodejs/tsc @nodejs/release and @nodejs/npm
/cc @zkat @iarna @bcoe @ceejbot