Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-tls-connect-memleak #21681

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 6, 2018

A loop that generates a long array is resulting in a RangeError. Moving
to Array.prototype.fill() along with the ** operator instead of using a
loop fixes the issue.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

A loop that generates a long array is resulting in a RangeError. Moving
to Array.prototype.fill() along with the ** operator instead of using a
loop fixes the issue.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 6, 2018
@Trott
Copy link
Member Author

Trott commented Jul 6, 2018

If this looks familiar, it's because it's very similar to #21681 #21658.

@lpinca
Copy link
Member

lpinca commented Jul 6, 2018

I think you mean #21658

@Trott
Copy link
Member Author

Trott commented Jul 6, 2018

I think you mean #21658

Yes. Yes, I do. :-D

@Trott
Copy link
Member Author

Trott commented Jul 6, 2018

Lite CI (as pummel tests don't run on CI): https://ci.nodejs.org/job/node-test-pull-request-lite/902/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 6, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jul 9, 2018
A loop that generates a long array is resulting in a RangeError. Moving
to Array.prototype.fill() along with the ** operator instead of using a
loop fixes the issue.

PR-URL: nodejs#21681
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 9, 2018

Landed in e56fec0

@Trott Trott closed this Jul 9, 2018
targos pushed a commit that referenced this pull request Jul 10, 2018
A loop that generates a long array is resulting in a RangeError. Moving
to Array.prototype.fill() along with the ** operator instead of using a
loop fixes the issue.

PR-URL: #21681
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@targos targos mentioned this pull request Jul 17, 2018
@Trott Trott deleted the fill-power branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants