Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check option start or end is not safe integer #21704

Conversation

shisama
Copy link
Contributor

@shisama shisama commented Jul 8, 2018

To increase fs readstream coverage, added test to check error when
option.start or end is not safe integer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

To increase fs readstream coverage, added test to check error when
option.start or end is not safe integer.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 8, 2018
@starkwang
Copy link
Contributor

@addaleax
Copy link
Member

Landed in 1f16758 🎉

@addaleax addaleax closed this Jul 10, 2018
addaleax pushed a commit that referenced this pull request Jul 10, 2018
To increase fs readstream coverage, added test to check error when
option.start or end is not safe integer.

PR-URL: #21704
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member

targos commented Jul 12, 2018

Depends on a major change: #19898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants