Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix structure and formatting in inspector.md #21709

Closed
wants to merge 1 commit into from
Closed

doc: fix structure and formatting in inspector.md #21709

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  1. Reorder some sections alphabetically.
  2. Fix some heading levels.
  3. Express a type of a property more formally.

Before:

1

After:

2

1. Reorder some sections alphabetically.
2. Fix some heading levels.
3. Express a type of a property more formally.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Jul 8, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 8, 2018
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2018
vsemozhetbyt added a commit that referenced this pull request Jul 8, 2018
1. Reorder some sections alphabetically.
2. Fix some heading levels.
3. Express a type of a property more formally.

PR-URL: #21709
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in c18a9d1
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-inspector-structure branch July 8, 2018 19:00
@targos targos added backport-requested-v10.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 10, 2018
@targos
Copy link
Member

targos commented Jul 10, 2018

Should land on v10.x-staging after #21659

targos pushed a commit that referenced this pull request Jul 18, 2018
1. Reorder some sections alphabetically.
2. Fix some heading levels.
3. Express a type of a property more formally.

PR-URL: #21709
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targos targos mentioned this pull request Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants