-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix structure and formatting in inspector.md #21709
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Reorder some sections alphabetically. 2. Fix some heading levels. 3. Express a type of a property more formally.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
inspector
Issues and PRs related to the V8 inspector protocol
labels
Jul 8, 2018
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Trott
approved these changes
Jul 8, 2018
vsemozhetbyt
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jul 8, 2018
claudiorodriguez
approved these changes
Jul 8, 2018
apapirovski
approved these changes
Jul 8, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 8, 2018
1. Reorder some sections alphabetically. 2. Fix some heading levels. 3. Express a type of a property more formally. PR-URL: #21709 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Landed in c18a9d1 |
targos
added
backport-requested-v10.x
and removed
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Jul 10, 2018
Should land on v10.x-staging after #21659 |
targos
pushed a commit
that referenced
this pull request
Jul 18, 2018
1. Reorder some sections alphabetically. 2. Fix some heading levels. 3. Express a type of a property more formally. PR-URL: #21709 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
inspector
Issues and PRs related to the V8 inspector protocol
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesBefore:
After: