-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use https://nodejs.org URL when possible. #21719
Conversation
BTW I searched the code base for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
On a side note, these might also need updating:
tools/pkgsrc/description:7:http://nodejs.org/
tools/rpm/node.spec:25:Source0: http://nodejs.org/dist/v%{_version}/node-v%{_version}.tar.gz
src/string_bytes.cc:346: // http://nodejs.org/api/buffer.html regarding Node's "ucs2"
src/string_bytes.cc:712: // http://nodejs.org/api/buffer.html regarding Node's "ucs2"
src/node_buffer.cc:486: // need to reorder on BE platforms. See http://nodejs.org/api/buffer.html
hundreds if not thousands of http links
Everything in node_modules
and deps
(and other thirdparty code locations) should be excluded.
@ChALkeR: I know but I didn't only search for I could have a stab at it later but I think the best would be if this would be split up in parts. For starters I could replace all nodejs.org links if you guys want in this PR. |
Done. I changed all the |
AIX CI re-run: https://ci.nodejs.org/job/node-test-commit-aix/16304/ |
Landed in 998f9ff 🎉 |
PR-URL: #21719 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #21719 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
No description provided.