-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n-api: test uint32 truncation #21722
Closed
gabrielschulhof
wants to merge
1
commit into
nodejs:master
from
gabrielschulhof:n-api-test-uint32-truncation
Closed
n-api: test uint32 truncation #21722
gabrielschulhof
wants to merge
1
commit into
nodejs:master
from
gabrielschulhof:n-api-test-uint32-truncation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
node-api
Issues and PRs related to the Node-API.
test
Issues and PRs related to the tests.
labels
Jul 9, 2018
addaleax
approved these changes
Jul 9, 2018
mhdawson
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cjihrig
approved these changes
Jul 10, 2018
jasnell
approved these changes
Jul 10, 2018
CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/15820/ |
gabrielschulhof
pushed a commit
that referenced
this pull request
Jul 12, 2018
Re: nodejs/abi-stable-node#55 (comment) PR-URL: #21722 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed in acf0606. |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2018
Re: nodejs/abi-stable-node#55 (comment) PR-URL: #21722 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: nodejs/abi-stable-node#55 (comment)
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes