Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 6.7.288.49 #21727

Closed
wants to merge 1 commit into from

Conversation

MylesBorins
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Jul 9, 2018
@MylesBorins
Copy link
Contributor Author

@addaleax
Copy link
Member

addaleax commented Jul 9, 2018

It doesn’t look like these changes affect us, right?

I guess it’s not an issue if you’re a Googler, but if your dev machine is near the lower end, recompiling all of V8 can be a real pain…

@MylesBorins
Copy link
Contributor Author

@addaleax we can hold off on landing this one and wait for changes that are more meaningful, generally trying to just keep us up to date with LKGR. Do these changes force a recompile?

@addaleax
Copy link
Member

addaleax commented Jul 9, 2018

Do these changes force a recompile?

I guess not, no … seems okay to me then?

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamp lgtm

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2018
@MylesBorins
Copy link
Contributor Author

landed in 9374a83

MylesBorins added a commit that referenced this pull request Jul 13, 2018
PR-URL: #21727
Refs: v8/v8@6.7.288.46...6.7.288.49
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Jul 14, 2018
PR-URL: #21727
Refs: v8/v8@6.7.288.46...6.7.288.49
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos mentioned this pull request Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants