Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: ICU 62.1 bump #21728

Closed
wants to merge 0 commits into from
Closed

deps: ICU 62.1 bump #21728

wants to merge 0 commits into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Jul 9, 2018 •
edited
Loading

Fixes: #21452

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

Note that this is a "normal" ICU bump, does not include full ICU ( #19214 ) unlike #21676

@srl295 srl295 added the i18n-api Issues and PRs related to the i18n implementation. label Jul 9, 2018
@srl295 srl295 self-assigned this Jul 9, 2018
@nodejs-github-bot
Copy link
Collaborator

@srl295 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/234/pipeline

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 9, 2018
@srl295
Copy link
Member Author

srl295 commented Jul 9, 2018

  • whitespace fixed for minimun diff

@srl295 srl295 changed the title deps: ICU 61.1 bump deps: ICU 62.1 bump Jul 9, 2018
@srl295
Copy link
Member Author

srl295 commented Jul 9, 2018 •
edited
Loading

  • commit message is wrong

srl295 added a commit to srl295/node that referenced this pull request Jul 9, 2018
@srl295
deps: ICU 62.1 bump (Unicode 11, CLDR 33.1)
57ce58d 
- Full release notes: http://site.icu-project.org/download/62

Fixes: nodejs#21452
X-PR-URL: nodejs#21728
jasnell
jasnell approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber-stamp lgtm

devsnek
devsnek approved these changes Jul 10, 2018
View reviewed changes
Copy link
Member

@devsnek devsnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping icu is always nice... dunno if i'm the best person to review though

richardlau
richardlau reviewed Jul 10, 2018
View reviewed changes
configure Outdated
@@ -1185,8 +1185,8 @@ def glob_to_var(dir_base, dir_sub, patch_dir):
def configure_intl(o):
icus = [
{
'url': 'https://ssl.icu-project.org/files/icu4c/61.1/icu4c-61_1-src.zip',
'md5': '780d8524c8a860ed8d8f6fe75cb7ce3f',
'url': 'https://sourceforge.net/projects/icu/files/ICU4C/62.1/icu4c-62_1-src.zip',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for the URL host change? https://ssl.icu-project.org/files/icu4c/62.1/icu4c-62_1-src.zip appears to exist.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ but is very slow. sourceforge has always been a valid mirror, in fact usually ICU redirects there.

srl295 added a commit that referenced this pull request Jul 10, 2018
@srl295
deps: icu 62.1 bump (Unicode 11, CLDR 33.1)
e0cc867 
- Full release notes: http://site.icu-project.org/download/62

Fixes: #21452
X-PR-URL: #21728

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@srl295 srl295 closed this Jul 10, 2018
@srl295 srl295 deleted the icu4c-62.1 branch July 10, 2018 22:08
@srl295
Copy link
Member Author

srl295 commented Jul 10, 2018

thx.. now icu is upgraded, and #21676 can be discussed on its own merits

@addaleax
Copy link
Member

Landed in 538acea

addaleax pushed a commit that referenced this pull request Jul 10, 2018
@srl295 @addaleax
deps: icu 62.1 bump (Unicode 11, CLDR 33.1)
538acea 
- Full release notes: http://site.icu-project.org/download/62

Fixes: #21452
PR-URL: #21728

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Jul 12, 2018
@srl295 @targos
deps: icu 62.1 bump (Unicode 11, CLDR 33.1)
122ae24 
- Full release notes: http://site.icu-project.org/download/62

Fixes: #21452
PR-URL: #21728

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos added a commit that referenced this pull request Jul 17, 2018
@targos
2018-07-18, Version 10.7.0 (Current)
68fc100 
Notable changes:

* console:
  * The `console.timeLog()` method has been implemented. (#21312)
* deps:
  * Upgrade to libuv 1.22.0. (#21731)
  * Upgrade to ICU 62.1 (Unicode 11, CLDR 33.1). (#21728)
* http:
  * Added support for passing both `timeout` and `agent` options to
    `http.request`. (#21204)
* napi:
  * Added experimental support for functions dealing with bigint numbers. (#21226)
* process:
  * The `process.hrtime.bigint()` method has been implemented. (#21256)
  * Added the `--title` command line argument to set the process title on
    startup. (#21477)
* trace_events:
  * Added process_name metadata. (#21477)
@targos targos mentioned this pull request Jul 17, 2018
Merged
targos added a commit that referenced this pull request Jul 18, 2018
@targos
2018-07-18, Version 10.7.0 (Current)
5543b9c 
Notable changes:

* console:
  * The `console.timeLog()` method has been implemented. (#21312)
* deps:
  * Upgrade to libuv 1.22.0. (#21731)
  * Upgrade to ICU 62.1 (Unicode 11, CLDR 33.1). (#21728)
* http:
  * Added support for passing both `timeout` and `agent` options to
    `http.request`. (#21204)
* napi:
  * Added experimental support for functions dealing with bigint numbers. (#21226)
* process:
  * The `process.hrtime.bigint()` method has been implemented. (#21256)
  * Added the `--title` command line argument to set the process title on
    startup. (#21477)
* trace_events:
  * Added process_name metadata. (#21477)
* Added new collaborators
  * codebytere - Shelley Vohr

PR-URL: #21851
targos added a commit that referenced this pull request Jul 18, 2018
@targos
2018-07-18, Version 10.7.0 (Current)
991bb95 
Notable changes:

* console:
  * The `console.timeLog()` method has been implemented.
    (#21312)
* deps:
  * Upgrade to libuv 1.22.0. (#21731)
  * Upgrade to ICU 62.1 (Unicode 11, CLDR 33.1).
    (#21728)
* http:
  * Added support for passing both `timeout` and `agent` options to
    `http.request`. (#21204)
* inspector:
  * Expose the original console API in `require('inspector').console`.
    (#21659)
* napi:
  * Added experimental support for functions dealing with bigint numbers.
    (#21226)
* process:
  * The `process.hrtime.bigint()` method has been implemented.
    (#21256)
  * Added the `--title` command line argument to set the process title on
    startup. (#21477)
* trace_events:
  * Added process_name metadata.
    (#21477)
* Added new collaborators
  * codebytere - Shelley Vohr

PR-URL: #21851
targos added a commit that referenced this pull request Jul 18, 2018
@targos
2018-07-18, Version 10.7.0 (Current)
bb87e41 
Notable changes:

* console:
  * The `console.timeLog()` method has been implemented.
    (#21312)
* deps:
  * Upgrade to libuv 1.22.0. (#21731)
  * Upgrade to ICU 62.1 (Unicode 11, CLDR 33.1).
    (#21728)
* http:
  * Added support for passing both `timeout` and `agent` options to
    `http.request`. (#21204)
* inspector:
  * Expose the original console API in `require('inspector').console`.
    (#21659)
* napi:
  * Added experimental support for functions dealing with bigint numbers.
    (#21226)
* process:
  * The `process.hrtime.bigint()` method has been implemented.
    (#21256)
  * Added the `--title` command line argument to set the process title on
    startup. (#21477)
* trace_events:
  * Added process_name metadata.
    (#21477)
* Added new collaborators
  * codebytere - Shelley Vohr

PR-URL: #21851
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

This does not land cleanly in v8.x LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@srl295
Copy link
Member Author

srl295 commented Aug 7, 2018 •
edited
Loading

@MylesBorins i think #22156 should be worked around before the backport

@srl295 srl295 mentioned this pull request Oct 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@devsnek devsnek devsnek approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@jasnell jasnell jasnell approved these changes

@bmeck bmeck bmeck approved these changes

@silverwind silverwind Awaiting requested review from silverwind

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees

@srl295 srl295

Labels
build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@srl295 @nodejs-github-bot @addaleax @MylesBorins @bmeck @jasnell @TimothyGu @richardlau @devsnek