test: fix flaky test-debug-prompt #21826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: nodejs#21724
|
Stress test to confirm this is a fix: https://ci.nodejs.org/job/node-stress-single-test/1965/nodes=osx1010/console Will run a similar stress test on master after it finishes. |
addaleax
approved these changes
Jul 15, 2018
2 tasks
apapirovski
approved these changes
Jul 15, 2018
lpinca
approved these changes
Jul 15, 2018
|
Stress test on this PR is green. Stress test on master is showing lots of failures pretty much right away (31 failures in 68 runs so far) so I'm going to terminate it: https://ci.nodejs.org/job/node-stress-single-test/1966/nodes=osx1010/ |
|
I'd like to fast-track this to greatly improve CI reliability. Please 👍 this comment if you approve fast-tracking. |
|
CI is green. If we can get a couple of fast-track 👍, this can land. |
JungMinu
approved these changes
Jul 16, 2018
maclover7
approved these changes
Jul 16, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jul 16, 2018
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: nodejs#21724 PR-URL: nodejs#21826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
Landed in df97126 |
targos
pushed a commit
that referenced
this pull request
Jul 16, 2018
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: #21724 PR-URL: #21826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This was referenced Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to send
.exitonly once to avoid spurious EPIPE and possiblyother errors.
Fixes: #21724
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes