Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make crashOnUnhandleRejection opt-out #21849

Closed
wants to merge 2 commits into from
Closed

test: make crashOnUnhandleRejection opt-out #21849

wants to merge 2 commits into from

Commits on Jul 19, 2018

  1. test: make crashOnUnhandleRejection opt-out 

    This commit removes `common.crashOnUnhandledRejection()` and adds
`common.disableCrashOnUnhandledRejection()`.

To reduce the risk of mistakes and make writing tests that involve
promises simpler, always install the unhandledRejection hook in tests
and provide a way to disable it for there rare cases where it's needed.
    @targos
    targos committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    b71506b View commit details
    Browse the repository at this point in the history

  2. alphabet

    @targos
    targos committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    a94af81 View commit details
    Browse the repository at this point in the history